From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A3371FFC40 for ; Fri, 17 Jan 2025 12:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737118729; cv=none; b=RGrakGMmDcN0tbPcJNxHxPaAPbkYu0/6W7vrX/WQPch0HpULBY82kwgL/2h2zSVpUMYBE0vCaMM1csfsMer/+GydJEErGc6H9ShRmmZNkgJHcPhmtpx9WNA3br9Kgja1uMB0G69uzqMwOUQP0UjBClN3M3iqcQpcfxO5Y685UoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737118729; c=relaxed/simple; bh=PlR6BI0pnwGwhH26X/m5utIA1jO/eGa1YHXFOyu++WE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=OmrhBeWsR7G7kphjYoYvD0BDxAW7Ee6CnWja04ns5Z3NMgeg0im9RFPsST5TX0nOXH4GJMSrOyJjQhGpAGhoU0IOCfIVgL137f1qeHIsOgHj0rtKZFa20XdW+XABITD+YA9M6CV8E6KcEwGttDa0FYQEHVRdPfqin+siYCdbSkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LproePKH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LproePKH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737118726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PlR6BI0pnwGwhH26X/m5utIA1jO/eGa1YHXFOyu++WE=; b=LproePKHCr8qiG3W1OdyD8m/zsaHpk7xnzqPOvYyp9coN5uTe5q6HuFZHUL8KTxVQ8qkx+ mUDc61R9OYfaSjindiRUm68ufHRoc2bS3HoMRyI73kYm1nxQw62h54TvwHd7WdW/RT/sjU bVhLJ+dWlB6Whn++TyBBPwHXRYQObsQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-GbZDt3vdNs2FdgZllq4-EA-1; Fri, 17 Jan 2025 07:58:45 -0500 X-MC-Unique: GbZDt3vdNs2FdgZllq4-EA-1 X-Mimecast-MFC-AGG-ID: GbZDt3vdNs2FdgZllq4-EA Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aa622312962so174306666b.2 for ; Fri, 17 Jan 2025 04:58:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737118724; x=1737723524; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PlR6BI0pnwGwhH26X/m5utIA1jO/eGa1YHXFOyu++WE=; b=t8HflIay16vnFHZXWpkAKKyPvPGEhTRGnibe6afddUsVmWc/D8MiTI9q6iex+pJxF1 HBoQpER/GSwSy7CIvAomW39iapznSbGESTfePc+WAIpOmWdMWh/uIBNANMbJj052kczR 2sG7FNqRFIvP8QlfyRU6ccpFvjER9KxWrFXpHm2QGUE7R3Pop80c1aBrw0MrTfiDFcnh 27MU42KTwJS+Aca2aM6Q7c/ZNk+xSd99OFdjzJJ0j9SLJE2rsXWrxCmlnu01dBsbXWlu +bP8/318dgcE+tlMHs3QBMQEDOkz9GL4ZySPx61wJQPrLblS5i+PZGIBiorlhkp2Dnr3 CR0g== X-Forwarded-Encrypted: i=1; AJvYcCUChECrHLUfMdq5YDXzmqagg7VFb/J0dNCh9A7xdqkN9fCn/W1ZDGjzVvuXnwJ1ThxDplkEXW5QIKJf4rs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo1AmPMIzjQc5zmnBurjasfrK176GRBDm0uxkuI6gdLZ8UbAjg u+X2vcuE+UHYcooOTHDjuttN3Z523Ei0ykvSG9dfAKuMo/8+rpoPjqGLyMU+Ot+D8ybjAnbcxNf 1+tzkXMyVCXdG7CJtoi2ccpx31gGG2YXLpnZVaFX6eLK0Gf/7MGWzNmnNA+jW1w== X-Gm-Gg: ASbGnctHkjlxPCLELmdte9qzkyKYwkY+kFixmXJC3PVyHNPILv8RUpjtQco+3MYMq3V EJMp7ediImSDNQrSHXXnG9VlGn0E/b4A+J2OKcLoxJZke0uxnG6q1+dTLEJTP60k58slM+uTVDa K+7Dz4Sy/IOzOIUBQagZA3D+uQNpqT++SEx0JqbPkgbSoJdOzo+z53gKNjVmpUxZ00kSf2J8dqw FTBfZ4E6d0Nm8CCw9UvQvlZSVyvMAU6eXH+mc+SVQswKcHC1CREELm/66Iw/npnONdIkDlai/Pd ZMM91g== X-Received: by 2002:a17:907:7ba9:b0:ab2:c0c8:383f with SMTP id a640c23a62f3a-ab38b0b684fmr250595666b.1.1737118723736; Fri, 17 Jan 2025 04:58:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGolLPypoV7vv1FU38Hl5hboOPUMjKRFS7YTrKUY9FAV3KoHCbQhbcHSkkSusXoVKy1aDv2tA== X-Received: by 2002:a17:907:7ba9:b0:ab2:c0c8:383f with SMTP id a640c23a62f3a-ab38b0b684fmr250593166b.1.1737118723388; Fri, 17 Jan 2025 04:58:43 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384ce11eesm167839466b.38.2025.01.17.04.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 04:58:43 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 35A4C17E7875; Fri, 17 Jan 2025 13:58:42 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Lobakin , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Alexander Lobakin , Lorenzo Bianconi , Daniel Xu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , John Fastabend , Jesper Dangaard Brouer , Martin KaFai Lau , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 7/8] veth: use napi_skb_cache_get_bulk() instead of xdp_alloc_skb_bulk() In-Reply-To: <20250115151901.2063909-8-aleksander.lobakin@intel.com> References: <20250115151901.2063909-1-aleksander.lobakin@intel.com> <20250115151901.2063909-8-aleksander.lobakin@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 17 Jan 2025 13:58:42 +0100 Message-ID: <871px1oav1.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alexander Lobakin writes: > Now that we can bulk-allocate skbs from the NAPI cache, use that > function to do that in veth as well instead of direct allocation from > the kmem caches. veth uses NAPI and GRO, so this is both context-safe > and beneficial. > > Signed-off-by: Alexander Lobakin Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen