From: Michael Ellerman <mpe@ellerman.id.au>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] macintosh/mac_hid: add MODULE_DESCRIPTION()
Date: Thu, 04 Jul 2024 22:30:43 +1000 [thread overview]
Message-ID: <871q49jq4s.fsf@mail.lhotse> (raw)
In-Reply-To: <20240509-mac_hid-md-v1-1-4091f1e4e4e0@quicinc.com>
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> Fix the make W=1 warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/macintosh/mac_hid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
> index 1ae3539beff5..eb7a173da071 100644
> --- a/drivers/macintosh/mac_hid.c
> +++ b/drivers/macintosh/mac_hid.c
> @@ -16,6 +16,7 @@
> #include <linux/module.h>
> #include <linux/slab.h>
>
> +MODULE_DESCRIPTION("Macintosh mouse button 2+3 emulation");
I dropped the "Macintosh" from this, because AIUI the driver is not
actually mac specific, despite where it lives in the tree.
cheers
next prev parent reply other threads:[~2024-07-04 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 1:23 [PATCH] macintosh/mac_hid: add MODULE_DESCRIPTION() Jeff Johnson
2024-07-04 12:30 ` Michael Ellerman [this message]
2024-07-06 23:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q49jq4s.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox