From: Takashi Iwai <tiwai@suse.de>
To: dberlin@dberlin.org
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for 2024 ROG Strix G634JZR
Date: Tue, 02 Apr 2024 08:13:54 +0200 [thread overview]
Message-ID: <871q7othp9.wl-tiwai@suse.de> (raw)
In-Reply-To: <874jckti4o.wl-tiwai@suse.de>
On Tue, 02 Apr 2024 08:04:39 +0200,
Takashi Iwai wrote:
>
> On Mon, 01 Apr 2024 16:31:30 +0200,
> Daniel Berlin via B4 Relay wrote:
> >
> > From: Daniel Berlin <dberlin@dberlin.org>
> >
> > The windows driver inf says it uses the exact same tunings and setup as the
> > older G634, and then reuses the data for ID 1043:1CAF.
> >
> > We do the same here.
> > Tested on an actual laptop, sound works fine with this patch plus
> > default fallback firmware.
> >
> > Signed-off-by: Daniel Berlin <dberlin@dberlin.org>
>
> Applied now. Thanks.
... and now I see that Luke has another patch that modified the entry
in patch_realtek.c, and I took his version instead.
https://lore.kernel.org/r/20240402015126.21115-1-luke@ljones.dev
Let me know if this causes problem for you.
thanks,
Takashi
prev parent reply other threads:[~2024-04-02 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 14:31 [PATCH] Add support for 2024 ROG Strix G634JZR Daniel Berlin via B4 Relay
[not found] ` <874jckti4o.wl-tiwai@suse.de>
2024-04-02 6:13 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q7othp9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=dberlin@dberlin.org \
--cc=james.schulman@cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox