public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Add support for 2024 ROG Strix G634JZR
@ 2024-04-01 14:31 Daniel Berlin via B4 Relay
       [not found] ` <874jckti4o.wl-tiwai@suse.de>
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Berlin via B4 Relay @ 2024-04-01 14:31 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
	Takashi Iwai
  Cc: alsa-devel, patches, linux-sound, linux-kernel, Daniel Berlin

From: Daniel Berlin <dberlin@dberlin.org>

The windows driver inf says it uses the exact same tunings and setup as the
older G634, and then reuses the data for ID 1043:1CAF.

We do the same here.
Tested on an actual laptop, sound works fine with this patch plus
default fallback firmware.

Signed-off-by: Daniel Berlin <dberlin@dberlin.org>
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 72ec872afb8d..25c117db3317 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -108,6 +108,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431F12", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
 	{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
+	{ "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
 	{ "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
@@ -496,6 +497,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431F12", generic_dsd_config },
 	{ "CSC3551", "10431F1F", generic_dsd_config },
 	{ "CSC3551", "10431F62", generic_dsd_config },
+	{ "CSC3551", "10433A60", generic_dsd_config },
 	{ "CSC3551", "17AA386F", generic_dsd_config },
 	{ "CSC3551", "17AA38A9", generic_dsd_config },
 	{ "CSC3551", "17AA38AB", generic_dsd_config },

---
base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f
change-id: 20240401-add-rog-strix-16-g634jzr-9e5490cadc2b

Best regards,
-- 
Daniel Berlin <dberlin@dberlin.org>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add support for 2024 ROG Strix G634JZR
       [not found] ` <874jckti4o.wl-tiwai@suse.de>
@ 2024-04-02  6:13   ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-04-02  6:13 UTC (permalink / raw)
  To: dberlin
  Cc: James Schulman, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
	alsa-devel, patches, linux-sound, linux-kernel

On Tue, 02 Apr 2024 08:04:39 +0200,
Takashi Iwai wrote:
> 
> On Mon, 01 Apr 2024 16:31:30 +0200,
> Daniel Berlin via B4 Relay wrote:
> > 
> > From: Daniel Berlin <dberlin@dberlin.org>
> > 
> > The windows driver inf says it uses the exact same tunings and setup as the
> > older G634, and then reuses the data for ID 1043:1CAF.
> > 
> > We do the same here.
> > Tested on an actual laptop, sound works fine with this patch plus
> > default fallback firmware.
> > 
> > Signed-off-by: Daniel Berlin <dberlin@dberlin.org>
> 
> Applied now.  Thanks.

... and now I see that Luke has another patch that modified the entry
in patch_realtek.c, and I took his version instead.
  https://lore.kernel.org/r/20240402015126.21115-1-luke@ljones.dev

Let me know if this causes problem for you.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-02  6:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 14:31 [PATCH] Add support for 2024 ROG Strix G634JZR Daniel Berlin via B4 Relay
     [not found] ` <874jckti4o.wl-tiwai@suse.de>
2024-04-02  6:13   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox