From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDA8EB64DA for ; Sat, 17 Jun 2023 07:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234415AbjFQHC6 (ORCPT ); Sat, 17 Jun 2023 03:02:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbjFQHCw (ORCPT ); Sat, 17 Jun 2023 03:02:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4747419A0 for ; Sat, 17 Jun 2023 00:02:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D203460C78 for ; Sat, 17 Jun 2023 07:02:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 395B6C433C9; Sat, 17 Jun 2023 07:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686985370; bh=mDjap47vtptdvQXYjii6QqSRgGmQnRM6EgD4Gp3rKyg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hEcO12pIj2UgGbu941bcI/B0dMQehv4dSlHAtI72llgnimuvPteZMPtyBw3BFQF8p mgadzCVHKe3a2UAYlRLjxidSCyJd0qsMhRKz0O9phZUTCWIBlp+Xl0dj+amjjkUQvg 2oO5pW9PsEXWihhoLrzMIbCayvtERXSeXFtJRc6xyHgTaMEgrK4+cSw/nSybgyk+2S D6fx9KrELyMT2AhYupanTQZuoblhwVOpACiCCtBBKIz769e1lI7swSfnQaCSQmf3ik UkoXRZlhMNTAeez8aolyEtlVoQLJSH0HCdQaF+QANh+y0069skZMDfPeM8nxXxzI5f 5pTMVfnTnx+4g== Received: from [77.240.177.73] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qAPxP-0063hb-Tf; Sat, 17 Jun 2023 08:02:48 +0100 Date: Sat, 17 Jun 2023 08:02:51 +0100 Message-ID: <871qiar2p0.wl-maz@kernel.org> From: Marc Zyngier To: Kunkun Jiang Cc: Thomas Gleixner , Zenghui Yu , "open list:IRQCHIP DRIVERS" , , , Subject: Re: [PATCH] irqchipi/gic-v4: Ensure accessing the correct RD when and writing INVLPIR In-Reply-To: References: <20230412041510.497-1-jiangkunkun@huawei.com> <86y1mxl9m4.wl-maz@kernel.org> <86bkikmvjk.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 77.240.177.73 X-SA-Exim-Rcpt-To: jiangkunkun@huawei.com, tglx@linutronix.de, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com, chenxiang66@hisilicon.com, tangnianyao@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 May 2023 13:01:59 +0100, Kunkun Jiang wrote: > > Hi Marc, > > On 2023/5/16 18:15, Marc Zyngier wrote: > > On Thu, 13 Apr 2023 04:57:17 +0100, > > Kunkun Jiang wrote: > >>> Wouldn't it be nice if irq_to_cpuid() could work out whether it is > >>> dealing with a LPI or a VLPI like it does today, but also directly > >>> with a VPE? We could then use the same code as derect_lpi_inv(). I > >>> came up with this the hack below, which is totally untested as I don't > >>> have access to GICv4.1 HW. > >>> > >>> Could you give it a spin? > >> Nice, I will test it as soon as possible. > > Did you ever managed to test this? > Sorry,I've only been coordinating the GICv4.1 environment in the last > few days. I have tested it with GICv4 many times, and it doesn't recur. > However, another call trace occurs with GICv4.1 when the device driver > is loaded in Guest. I haven't found out why. Maybe you can help analyze it. Which driver is loaded in the guest? As I said, I don't have the HW at all, so I cannot test things, and this stack-trace is not enough to analyse anything (you're not even saying what you are doing). M. -- Without deviation from the norm, progress is not possible.