From: Marc Zyngier <maz@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zheng Wang <zyytlz.wz@163.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error
Date: Mon, 29 May 2023 12:15:30 +0100 [thread overview]
Message-ID: <871qizl771.wl-maz@kernel.org> (raw)
In-Reply-To: <OS0PR01MB59227D8298776A092F024F2A864A9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Mon, 29 May 2023 11:03:27 +0100,
Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> > Do you understand the meaning of the "dev" parameter you pass to
> > devm_request_irq()?
>
> Yes, the resource is managed with particular device.
So what does it tell you about the life cycle of the interrupt you
request with the *wrong* device?
> I should not use devm_request_irq here. rather should use
> request_irq and free_irq during unload with parent device handle.
No, that's just papering over the real issue. You should just get the
driver that handles the interrupt to request it. Anything else is a
design bug.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-05-29 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230526143615.372338-1-biju.das.jz@bp.renesas.com>
[not found] ` <20230529061714.GA25984@pendragon.ideasonboard.com>
2023-05-29 8:42 ` [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error Biju Das
2023-05-29 8:56 ` Laurent Pinchart
2023-05-29 9:12 ` Marc Zyngier
2023-05-30 12:37 ` Biju Das
2023-05-30 13:16 ` Geert Uytterhoeven
2023-05-30 13:47 ` Biju Das
2023-05-29 9:09 ` Marc Zyngier
2023-05-29 9:39 ` Biju Das
2023-05-29 9:46 ` Laurent Pinchart
2023-05-29 9:59 ` Biju Das
2023-05-29 9:56 ` Marc Zyngier
2023-05-29 10:03 ` Biju Das
2023-05-29 11:15 ` Marc Zyngier [this message]
2023-05-29 13:20 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qizl771.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox