From: Jani Nikula <jani.nikula@linux.intel.com>
To: min tang <tangmin@cdjrlc.com>,
airlied@linux.ie, daniel@ffwll.ch,
srinivas.pandruvada@linux.intel.com
Cc: min tang <tangmin@cdjrlc.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] drm/i915/gt: Unneeded semicolon
Date: Mon, 15 Aug 2022 12:28:38 +0300 [thread overview]
Message-ID: <871qthsvnd.fsf@intel.com> (raw)
In-Reply-To: <20220813151616.4193-1-tangmin@cdjrlc.com>
On Sat, 13 Aug 2022, min tang <tangmin@cdjrlc.com> wrote:
> There is no semicolon after '}' in line 648.
>
> Signed-off-by: min tang <tangmin@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
This part is fine.
> tools/power/x86/intel-speed-select/hfi-events.c | 2 +-
> tools/testing/selftests/timers/nanosleep.c | 2 +-
These need to be split out and sent to their respective subsystems.
BR,
Jani.
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> diff --git a/tools/power/x86/intel-speed-select/hfi-events.c b/tools/power/x86/intel-speed-select/hfi-events.c
> index 761375062505..f0ed69721308 100644
> --- a/tools/power/x86/intel-speed-select/hfi-events.c
> +++ b/tools/power/x86/intel-speed-select/hfi-events.c
> @@ -144,7 +144,7 @@ static int family_handler(struct nl_msg *msg, void *arg)
> continue;
> res->id = nla_get_u32(tb2[CTRL_ATTR_MCAST_GRP_ID]);
> break;
> - };
> + }
>
> return 0;
> }
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 71b5441c2fd9..433a09676aeb 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-08-15 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 15:16 [PATCH] drm/i915/gt: Unneeded semicolon min tang
2022-08-15 9:28 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qthsvnd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tangmin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox