From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45551CCA473 for ; Mon, 25 Jul 2022 06:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbiGYGdA (ORCPT ); Mon, 25 Jul 2022 02:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiGYGc6 (ORCPT ); Mon, 25 Jul 2022 02:32:58 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9795DEBC for ; Sun, 24 Jul 2022 23:32:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F13135214; Mon, 25 Jul 2022 06:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658730776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P1LXcn+hKt49MBdlgeZ82zxYZFLVTBrIq3FWrHSmwmA=; b=oUJy5dpT1PfTeMsYPEbfWNYwllEopChogBV53EDYgX9V++PiZj/MfKAaNT0CH8QiemvC6e NFpSvk6FDhi3UX1SEdLYVBdgwkV33l4rfnN3ZF92dee0D5EwilJp8Am22+mVaaV5XCmTJX L8iN92/KeScuxwnwnFJ86I8b5s12T6k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658730776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P1LXcn+hKt49MBdlgeZ82zxYZFLVTBrIq3FWrHSmwmA=; b=1dHrctAwEAi++CA4JlU4TjuL3O24usA1XTAzFSzEorlZLO8Qr2MWRr1fVp2yE6Ui/MFc7v JG1i2QihP2rWA8AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 448FD13AD7; Mon, 25 Jul 2022 06:32:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DM0XEBg53mIdQAAAMHmgww (envelope-from ); Mon, 25 Jul 2022 06:32:56 +0000 Date: Mon, 25 Jul 2022 08:32:55 +0200 Message-ID: <871qu9em7c.wl-tiwai@suse.de> From: Takashi Iwai To: Ren Zhijie Cc: , , , , , , , , patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function In-Reply-To: <20220725023611.57055-1-renzhijie2@huawei.com> References: <20220725023611.57055-1-renzhijie2@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2022 04:36:11 +0200, Ren Zhijie wrote: > > If CONFIG_PM_SLEEP is not set, > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: > > sound/pci/hda/cs35l41_hda.c:583:12: error: ˇcs35l41_runtime_resume˘ defined but not used [-Werror=unused-function] > static int cs35l41_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~ > sound/pci/hda/cs35l41_hda.c:565:12: error: ˇcs35l41_runtime_suspend˘ defined but not used [-Werror=unused-function] > static int cs35l41_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1 > > commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, > deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem. > > Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend") > Signed-off-by: Ren Zhijie Thanks, applied. Takashi