From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFAFC433F5 for ; Wed, 16 Mar 2022 15:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357284AbiCPPnm (ORCPT ); Wed, 16 Mar 2022 11:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242407AbiCPPnk (ORCPT ); Wed, 16 Mar 2022 11:43:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 609736D193 for ; Wed, 16 Mar 2022 08:42:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F200561693 for ; Wed, 16 Mar 2022 15:42:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6507EC340E9; Wed, 16 Mar 2022 15:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647445345; bh=J5ZkX6POaKKLpqerhVssLGbX3hMhlpc03GUaoFBIzeM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O2u99JQ57zOZ/Oj6y6WPMSRwsrz/IJRGNFMu2x0K6jmCvwLF7F174psFCE+K5jW7/ DanqYtvgPs3af0exFI4e1T/HzDz+S+iuTPW9IjP0mrtWEEnRfLe/wbKzbiyVO0R+24 joo0UEwYLOcEa7xbwB1ZtdYW0spFzEANqB6jtZtoYPimNQfVc486SeH87FAvEjrqHp SgzVAUC/G5TaUU5uAPCSOKQKjyDIHIh2Tc94ravTjecbBgqifE8avN5btR7cMOrw83 B65iCOE8kMVhRmWe4d5Pgnn4a+5ezEL8p1Vz2E4tDACVip3w8nbQZrIwp9xhtKDd1N tnFnGqZxx+nUA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUVn3-00Exff-Fs; Wed, 16 Mar 2022 15:42:23 +0000 Date: Wed, 16 Mar 2022 15:42:21 +0000 Message-ID: <871qz1zyxu.wl-maz@kernel.org> From: Marc Zyngier To: Andre Przywara Cc: linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Thomas Gleixner , Eric Auger Subject: Re: [PATCH 3/3] irqchip/gic-v3: Relax polling of GIC{R,D}_CTLR.RWP In-Reply-To: <20220316145403.51475e25@slackpad.lan> References: <20220315165034.794482-1-maz@kernel.org> <20220315165034.794482-4-maz@kernel.org> <20220316145403.51475e25@slackpad.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: andre.przywara@arm.com, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, tglx@linutronix.de, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2022 14:54:03 +0000, Andre Przywara wrote: > > On Tue, 15 Mar 2022 16:50:34 +0000 > Marc Zyngier wrote: > > Hi, > > > Recent work on the KVM GIC emulation has revealed that the GICv3 > > driver is a bit RWP-happy, as it polls this bit for each and > > every write MMIO access involving a single interrupt. > > > > As it turns out, polling RWP is only required when: > > - Disabling an SGI, PPI or SPI > > - Disabling LPIs at the redistributor level > > - Disabling groups > > - Enabling ARE > > - Dealing with DPG* > > > > Simplify the driver by removing all the other instances of RWP > > polling, and add the one that was missing when enabling the distributor > > (as that's where we set ARE). > > Don't we need an explicit call to wait_for_rwp() now for: > gic_irq_set_irqchip_state(IRQCHIP_STATE_MASKED, true) ? Ah, yes, I missed that one. Thanks. > IMPORTANT NOTICE: The contents of this email [...] The ARM IT crap is firing again. Wrong SMTP server? M. -- Without deviation from the norm, progress is not possible.