From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F63BC433DB for ; Sun, 3 Jan 2021 16:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8AEE20B1F for ; Sun, 3 Jan 2021 16:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbhACQok (ORCPT ); Sun, 3 Jan 2021 11:44:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:60228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbhACQoj (ORCPT ); Sun, 3 Jan 2021 11:44:39 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2404D20780; Sun, 3 Jan 2021 16:43:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kw6U0-0055el-Us; Sun, 03 Jan 2021 16:43:57 +0000 Date: Sun, 03 Jan 2021 16:43:55 +0000 Message-ID: <871rf2km2c.wl-maz@kernel.org> From: Marc Zyngier To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , Arnd Bergmann , James Morse , Julien Thierry , Suzuki K Poulose , David Brazdil , Paolo Bonzini , Sean Christopherson , Andrew Scull , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: remove incorrect __init annotation In-Reply-To: <20210103140104.3853922-1-arnd@kernel.org> References: <20210103140104.3853922-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: arnd@kernel.org, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, dbrazdil@google.com, pbonzini@redhat.com, seanjc@google.com, ascull@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Jan 2021 14:00:50 +0000, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When hyp_cpu_pm_exit() is not inlined, it causes a link time warning: > > WARNING: modpost: vmlinux.o(.text+0x39974): Section mismatch in reference from the function kvm_arch_init() to the function .init.text:hyp_cpu_pm_exit() > The function kvm_arch_init() references > the function __init hyp_cpu_pm_exit(). > This is often because kvm_arch_init lacks a __init > annotation or the annotation of hyp_cpu_pm_exit is wrong. > > This is not only called at boot time, so remove the annotation > to prevent undefined behavior in case it gets called after being > freed. It *is* only called at boot time (despite these functions being called from module_init(), KVM cannot be built as a module on arm64). The annotations are wrong nonetheless. > > Signed-off-by: Arnd Bergmann Posted here [1], and queued for the next batch of fixes. M. [1] https://lore.kernel.org/linux-arm-kernel/20201223120854.255347-1-maz@kernel.org -- Without deviation from the norm, progress is not possible.