From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0F5C32789 for ; Wed, 7 Nov 2018 00:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC7B420827 for ; Wed, 7 Nov 2018 00:59:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC7B420827 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388713AbeKGK1Z (ORCPT ); Wed, 7 Nov 2018 05:27:25 -0500 Received: from ozlabs.org ([203.11.71.1]:52633 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388174AbeKGK1Y (ORCPT ); Wed, 7 Nov 2018 05:27:24 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42qSjh65Vfz9sDL; Wed, 7 Nov 2018 11:59:20 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Mike Snitzer Cc: axboe@kernel.dk, linuxppc-dev@lists.ozlabs.org, satheera@in.ibm.com, Linus Torvalds , Linux Kernel Mailing List Subject: Re: System not booting since dm changes? (was Linux 4.20-rc1) In-Reply-To: <20181105135157.GA11485@redhat.com> References: <87tvkvddnk.fsf@concordia.ellerman.id.au> <20181105135157.GA11485@redhat.com> Date: Wed, 07 Nov 2018 11:59:20 +1100 Message-ID: <871s7xsnx3.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Snitzer writes: > On Mon, Nov 05 2018 at 5:25am -0500, > Michael Ellerman wrote: > >> Linus Torvalds writes: >> ... >> > Mike Snitzer (1): >> > device mapper updates >> >> Hi Mike, >> >> Replying here because I can't find the device-mapper pull or the patch >> in question on LKML. I guess I should be subscribed to dm-devel. >> >> We have a box that doesn't boot any more, bisect points at one of: >> >> cef6f55a9fb4 Mike Snitzer dm table: require that request-based DM be layered on blk-mq devices >> 953923c09fe8 Mike Snitzer dm: rename DM_TYPE_MQ_REQUEST_BASED to DM_TYPE_REQUEST_BASED >> 6a23e05c2fe3 Jens Axboe dm: remove legacy request-based IO path >> >> >> It's a Power8 system running Rawhide, it does have multipath, but I'm >> told it was setup by the Fedora installer, ie. nothing fancy. >> >> The symptom is the system can't find its root filesystem and drops into >> the initramfs shell. The dmesg includes a bunch of errors like below: >> >> [ 43.263460] localhost multipathd[1344]: sdb: fail to get serial >> [ 43.268762] localhost multipathd[1344]: mpatha: failed in domap for addition of new path sdb >> [ 43.268762] localhost multipathd[1344]: uevent trigger error >> [ 43.282065] localhost kernel: device-mapper: table: table load rejected: not all devices are blk-mq request-stackable > ... >> >> Any ideas what's going wrong here? > > "table load rejected: not all devices are blk-mq request-stackable" > speaks to the fact that you aren't using blk-mq for scsi (aka scsi-mq). > > You need to use scsi_mod.use_blk_mq=Y on the kernel commandline (or set > CONFIG_SCSI_MQ_DEFAULT in your kernel config) Thanks. Looks like CONFIG_SCSI_MQ_DEFAULT is default y, so new configs should pick that up by default. We must have had an old .config that didn't get that update. cheers