public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Anurag Kumar Vulisha <anuragku@xilinx.com>,
	Anurag Kumar Vulisha <anuragku@xilinx.com>,
	"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "v.anuragkumar\@gmail.com" <v.anuragkumar@gmail.com>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Thinh.Nguyen\@synopsys.com" <Thinh.Nguyen@synopsys.com>,
	Ajay Yugalkishore Pandey <APANDEY@xilinx.com>
Subject: RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver
Date: Tue, 09 Oct 2018 08:36:47 +0300	[thread overview]
Message-ID: <871s8zptow.fsf@linux.intel.com> (raw)
In-Reply-To: <BL0PR02MB563373F068BC275BCB14DBE3A7E60@BL0PR02MB5633.namprd02.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]


(no top-posting, please)

Hi,


Anurag Kumar Vulisha <anuragku@xilinx.com> writes:

> Hi Felipe,
>
> Please let us know if you have any suggestions / comments on this patch series.
> If you feel this patch series are okay, can we proceed with them?

I really don't like this dwc3-specific timer. The best way here would be
to add a timer on udc/core.c which can be reused by any udc. This would
mean, of course, teaching udc/core about streams and lettting it do part
of the handling.

Best

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-10-09  5:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-15 14:29 [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 2/8] usb: dwc3: update stream id in depcmd Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 3/8] usb: dwc3: make controller clear transfer resources after complete Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 4/8] usb: dwc3: implement stream transfer timeout Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 6/8] usb: dwc3: check for requests in started list " Anurag Kumar Vulisha
2018-09-15 14:30 ` [PATCH v5 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Anurag Kumar Vulisha
2018-09-15 14:30 ` [PATCH v5 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints Anurag Kumar Vulisha
2018-09-21  2:53 ` [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Tejas Joglekar
2018-09-21 13:31 ` Tejas Joglekar
2018-09-21 14:05   ` Anurag Kumar Vulisha
2018-09-24  4:57     ` Tejas Joglekar
2018-10-08 15:25 ` Anurag Kumar Vulisha
2018-10-09  5:36   ` Felipe Balbi [this message]
2018-10-09  6:38     ` Anurag Kumar Vulisha
2018-10-09  7:20       ` Felipe Balbi
2018-10-09 13:00         ` Anurag Kumar Vulisha
2018-10-09 13:04           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s8zptow.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=APANDEY@xilinx.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=anuragku@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=v.anuragkumar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox