From: Felipe Balbi <balbi@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
gregkh@linuxfoundation.org, bhumirks@gmail.com,
leoyang.li@nxp.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup
Date: Mon, 12 Feb 2018 10:48:04 +0200 [thread overview]
Message-ID: <871shqbnln.fsf@linux.intel.com> (raw)
In-Reply-To: <cover.1515791144.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
Hi,
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> This serie aims to fix 2 issues. (path 2 & 4)
>
> The 2nd patch fixes a memory leak. It uses devm_ function a simplify the
> handling of the memory.
>
> The 4th patch fixes a potential invalid pointer dereference.
>
> The 2 other ones, are just clean-ups to remove useless code and add other
> uses of devm_ function to simplify code.
>
> I've left the request_irq/free_irq because I'm unsure of potential side
> effects if some other resources are freed while an IRQ can still be
> triggered. So I've preferred to leave it as-is.
>
> Christophe JAILLET (4):
> usb: gadget: fotg210-udc: Remove a useless
> usb: gadget: fotg210-udc: Fix a memory leak
> usb: gadget: fotg210-udc: Simplify code
> usb: gadget: fotg210-udc: Fix a potential invalid pointer dereference
you should NEVER make fixes depend on cleanups. It should be the other
way around :-) First fixes, then cleanups. The reason is that fixes can
get accepted during -rc cycle, but cleanups must wait until the next
merge window.
Please fix up your patches, otherwise I'll have to apply the entire
series for v4.17
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-02-12 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:41 [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup Christophe JAILLET
2018-01-12 21:44 ` [PATCH 1/4] usb: gadget: fotg210-udc: Remove a useless Christophe JAILLET
2018-01-12 21:44 ` [PATCH 2/4] usb: gadget: fotg210-udc: Fix a memory leak Christophe JAILLET
2018-01-12 21:44 ` [PATCH 3/4] usb: gadget: fotg210-udc: Simplify code Christophe JAILLET
2018-01-12 21:44 ` [PATCH 4/4] usb: gadget: fotg210-udc: Fix a potential invalid pointer dereference Christophe JAILLET
2018-02-12 8:48 ` Felipe Balbi [this message]
2018-02-12 18:05 ` [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup Christophe Jaillet
2018-02-17 10:50 ` Hans Ulli Kroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871shqbnln.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=bhumirks@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).