From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Wei Xu <xuwei5@hisilicon.com>, Guodong Xu <guodong.xu@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
YongQin Liu <yongqin.liu@linaro.org>,
John Youn <johnyoun@synopsys.com>,
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
Douglas Anderson <dianders@chromium.org>,
Chen Yu <chenyu56@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux USB List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling
Date: Wed, 11 Oct 2017 13:11:46 +0300 [thread overview]
Message-ID: <871smam1st.fsf@linux.intel.com> (raw)
In-Reply-To: <CALAqxLXhmp8BoR5_8d27bLJSibLnJstARpvb8jUMPWmf1i9igw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Hi,
John Stultz <john.stultz@linaro.org> writes:
> On Thu, Aug 17, 2017 at 12:03 PM, John Stultz <john.stultz@linaro.org> wrote:
>> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
>> disconnect the gadget state"), I was trying to fix up the
>> fact that we somehow weren't disconnecting the gadget state,
>> so that when the OTG port was plugged in the second time we
>> would get warnings about the state tracking being wrong.
>>
>> The fix there was somewhat simple, as it just made sure to
>> call dwc2_hsotg_disconnect() before we connected things up
>> in OTG mode.
>>
>> But in looking at a different issue I was seeing with UDC
>> state handling, I realized that it would be much better
>> to call dwc2_hsotg_disconnect when we get the state change
>> signal moving to host mode.
>>
>> Thus, this patch removes the earlier disconnect call I added
>> and moves it (and the needed locking) to the host mode
>> transition.
>
> Ping? I don't mean to be a bother, but any thoughts on this patchset?
I'm not taking patches which John hasn't acked, sorry.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-10-11 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 19:03 [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling John Stultz
2017-08-17 19:03 ` [PATCH 2/3] usb: dwc2: Fix UDC state tracking John Stultz
2017-08-17 19:03 ` [PATCH 3/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode John Stultz
2017-08-25 23:16 ` [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling John Stultz
2017-10-11 10:11 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871smam1st.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=amit.pundir@linaro.org \
--cc=chenyu56@huawei.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=johnyoun@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).