From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752922AbdJKKMJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Oct 2017 06:12:09 -0400
Received: from mga09.intel.com ([134.134.136.24]:46275 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750705AbdJKKMH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Oct 2017 06:12:07 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,360,1503385200"; 
   d="asc'?scan'208";a="1229539572"
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>, Wei Xu <xuwei5@hisilicon.com>,
        Guodong Xu <guodong.xu@linaro.org>,
        Amit Pundir <amit.pundir@linaro.org>,
        YongQin Liu <yongqin.liu@linaro.org>,
        John Youn <johnyoun@synopsys.com>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Douglas Anderson <dianders@chromium.org>,
        Chen Yu <chenyu56@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux USB List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling
In-Reply-To: <CALAqxLXhmp8BoR5_8d27bLJSibLnJstARpvb8jUMPWmf1i9igw@mail.gmail.com>
References: <1502996595-15316-1-git-send-email-john.stultz@linaro.org> <CALAqxLXhmp8BoR5_8d27bLJSibLnJstARpvb8jUMPWmf1i9igw@mail.gmail.com>
Date: Wed, 11 Oct 2017 13:11:46 +0300
Message-ID: <871smam1st.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

John Stultz <john.stultz@linaro.org> writes:
> On Thu, Aug 17, 2017 at 12:03 PM, John Stultz <john.stultz@linaro.org> wr=
ote:
>> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
>> disconnect the gadget state"), I was trying to fix up the
>> fact that we somehow weren't disconnecting the gadget state,
>> so that when the OTG port was plugged in the second time we
>> would get warnings about the state tracking being wrong.
>>
>> The fix there was somewhat simple, as it just made sure to
>> call dwc2_hsotg_disconnect() before we connected things up
>> in OTG mode.
>>
>> But in looking at a different issue I was seeing with UDC
>> state handling, I realized that it would be much better
>> to call dwc2_hsotg_disconnect when we get the state change
>> signal moving to host mode.
>>
>> Thus, this patch removes the earlier disconnect call I added
>> and moves it (and the needed locking) to the host mode
>> transition.
>
> Ping? I don't mean to be a bother, but any thoughts on this patchset?

I'm not taking patches which John hasn't acked, sorry.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlnd7mIACgkQzL64meEa
mQa83g//RAzrg4+8onadxLyMijlD+komXyiZGNRhBt2u6y8DRQ2IR+cOOjYfmtc6
pirQ31U6ftxTZokV3cQfkUkNUj46rvDmbiH3k+2QN2vwHmG24K6e+bW/NKrNusNk
Ad4ZP8CUFdhG/zNDrDGFRorZpVSGDUwJCxlDmBX0Oni0EQpC+expBKhZ3SH9e7q+
PF7DAVQBB7wkKTxK3eBbyxq5a+evNEntf1MwuF7aa1QRG9xzlPOA4UIvQzP5PhAg
r6lk6wpybt/pAl00nDWV7hm0iqoEMoyrinH97LFP8AbqkqtVRHxTW5lck7zrlejO
Q7ZLmqcpNlEEuz579h0oBa0bur2JmahN2Cb4QWIHfDj0jiednt0e9ED2PshVOPRb
Y1jDXWqFiztarFfpw40Ezra7W3A16VaQOjf8zvDQgZtFNzkClm/gug/UsCWcu2kk
ZfbIlSYa3iwO6Rkwdds90C8646kZ2aEcCrKh4ymhXLhaAPbL/7DObOntE9xj/uNZ
nOAI7I8dgPtmuVmD6rZxwJcKnuu/AWbXS1/TMHfVH4pLyQSmp3MK4KAF8PoORWaZ
uOIz9oJw1+y66clz3oPEc7IarrgnUN/QZxbe57zIjdBm1ab5/xemdPeqxdcBC7oc
ZrT3y483wMFKF3zUcsNxL2oJS5qjT0kjOyWypmM2QgliIOSnt28=
=GPMV
-----END PGP SIGNATURE-----
--=-=-=--