From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932803AbdJKBLh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 21:11:37 -0400
Received: from mga05.intel.com ([192.55.52.43]:10834 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932675AbdJKBLU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 21:11:20 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,359,1503385200"; 
   d="scan'208";a="161225968"
From: "Huang\, Ying" <ying.huang@intel.com>
To: Minchan Kim <minchan@kernel.org>
Cc: "Huang\, Ying" <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
        "Rik van Riel" <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
        Hugh Dickins <hughd@google.com>, Fengguang Wu <fengguang.wu@intel.com>,
        Tim Chen <tim.c.chen@intel.com>, Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH -mm] mm, swap: Use page-cluster as max window of VMA based swap readahead
References: <20171010060855.17798-1-ying.huang@intel.com>
        <20171010082040.GA16508@bbox> <87r2ubo08t.fsf@yhuang-dev.intel.com>
        <20171010085524.GA16752@bbox>
Date: Wed, 11 Oct 2017 09:11:17 +0800
In-Reply-To: <20171010085524.GA16752@bbox> (Minchan Kim's message of "Tue, 10
        Oct 2017 17:55:24 +0900")
Message-ID: <871smao5e2.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Minchan Kim <minchan@kernel.org> writes:

> On Tue, Oct 10, 2017 at 04:50:10PM +0800, Huang, Ying wrote:
>> Minchan Kim <minchan@kernel.org> writes:
>> 
>> > On Tue, Oct 10, 2017 at 02:08:55PM +0800, Huang, Ying wrote:
>> >> From: Huang Ying <ying.huang@intel.com>
>> >> 
>> >> When the VMA based swap readahead was introduced, a new knob
>> >> 
>> >>   /sys/kernel/mm/swap/vma_ra_max_order
>> >> 
>> >> was added as the max window of VMA swap readahead.  This is to make it
>> >> possible to use different max window for VMA based readahead and
>> >> original physical readahead.  But Minchan Kim pointed out that this
>> >> will cause a regression because setting page-cluster sysctl to zero
>> >> cannot disable swap readahead with the change.
>> >> 
>> >> To fix the regression, the page-cluster sysctl is used as the max
>> >> window of both the VMA based swap readahead and original physical swap
>> >> readahead.  If more fine grained control is needed in the future, more
>> >> knobs can be added as the subordinate knobs of the page-cluster
>> >> sysctl.
>> >> 
>> >> The vma_ra_max_order knob is deleted.  Because the knob was
>> >> introduced in v4.14-rc1, and this patch is targeting being merged
>> >> before v4.14 releasing, there should be no existing users of this
>> >> newly added ABI.
>> >> 
>> >> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> >> Cc: Rik van Riel <riel@redhat.com>
>> >> Cc: Shaohua Li <shli@kernel.org>
>> >> Cc: Hugh Dickins <hughd@google.com>
>> >> Cc: Fengguang Wu <fengguang.wu@intel.com>
>> >> Cc: Tim Chen <tim.c.chen@intel.com>
>> >> Cc: Dave Hansen <dave.hansen@intel.com>
>> >> Reported-by: Minchan Kim <minchan@kernel.org>
>> >
>> > It seems your script is Ccing only with Cc: tag, not other tags.
>> > Fix it so any participant of topic can get the mail.
>> 
>> I just used `git send-email`, no other scripts.  We need to fix `git send-email`?
>
> You can do it via cccmd.
>
> Just a reference:
>
> ~/bin/kcccmd
> sed -nre 's/^(Acked|Reviewed|Reported|Tested|Suggested)-by: //p' "$1"

Thanks, will use this script in the future.

Best Regards,
Huang, Ying