From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, Eric Anholt <eric@anholt.net>
Cc: Colin King <colin.king@canonical.com>,
Tom Cooksey <tom.cooksey@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static
Date: Tue, 23 May 2017 11:19:58 +0300 [thread overview]
Message-ID: <871srgouhd.fsf@intel.com> (raw)
In-Reply-To: <20170519201641.fwnoakx5gew7wo5t@mwanda>
On Fri, 19 May 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote:
>> OK, that's definitely not how I've read the
>> Documentation/process/submitting-patches.rst description of the Fixes
>> tag, which talks about bugs found with git bisect and things that should
>> go to -stable. I would not have considered what this patch is changing
>> to be a bug.
>
> True. I don't consider this a bug either. I wouldn't have included a
> Fixes tag.
>
> I pretty much agree with the submitting-patches.rst except it should
> probably say to include it on more stuff. Fixes: tags are required for
> all bugfixes to netdev for example.
We use Fixes: in drm/i915 to basically indicate that the referenced
commit has a bug that actually needs to be fixed, this patch is the fix,
and should go wherever the referenced commit goes. Annotating typo fixes
and missing static keywords and such is just noise from *our* POV, and
need to be filtered out.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-05-23 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 11:02 [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Colin King
2017-05-19 12:03 ` Jani Nikula
2017-05-19 18:19 ` Eric Anholt
2017-05-19 19:40 ` Dan Carpenter
2017-05-19 19:47 ` Dan Carpenter
2017-05-19 20:08 ` Eric Anholt
2017-05-19 20:16 ` Dan Carpenter
2017-05-23 8:19 ` Jani Nikula [this message]
2017-05-23 8:31 ` Dan Carpenter
2017-05-23 13:01 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871srgouhd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.cooksey@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox