From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875AbcH2INo (ORCPT ); Mon, 29 Aug 2016 04:13:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:7972 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756797AbcH2INm (ORCPT ); Mon, 29 Aug 2016 04:13:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,595,1464678000"; d="asc'?scan'208";a="1042786835" From: Felipe Balbi To: Romain Izard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Romain Izard Subject: Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information In-Reply-To: <1469550106-16067-1-git-send-email-romain.izard.pro@gmail.com> References: <1469550106-16067-1-git-send-email-romain.izard.pro@gmail.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Mon, 29 Aug 2016 11:13:25 +0300 Message-ID: <871t18dmca.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Romain Izard writes: > Disabling USB gadget functions configured through configfs is something > that can happen in normal use cases. Keep the existing log for this type > of event, but only as information, not as an error. > > Signed-off-by: Romain Izard > --- > drivers/usb/gadget/configfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index 70cf3477f951..11f3a649d9e5 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info = *gi) >=20=20 > list_move_tail(&f->list, &cfg->func_list); > if (f->unbind) { > - dev_err(&gi->cdev.gadget->dev, "unbind function" > - " '%s'/%p\n", f->name, f); > + dev_info(&gi->cdev.gadget->dev, seems to me dev_dbg() is a far better alternative. We really don't need this on everybody's log buffer unless they really _are_ debugging some possible issues. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXw+6lAAoJEIaOsuA1yqREDQYP/0Eon8XFiVs7d6jgMERCLr6M 4aiGjUVcBdmjDlTDdGc1nrNHMSvA2xG/DpLrsPZvx/N2LAvsNVMy79ntdFTIJadD PNYqBsoVtK+7PMf2VsQTOS20XITZ0xx6t9pQTg26G2njF9xSWu1XrtN80fw4HKY2 +N4tQNP/NeyzZBSw4y0CTuIa6Uu2t0xsxXIXweLCMwwNNKoQi0VLuKQ3R0LfjlWc 4MZ2HT0qYc5ju5TgOcLfH71XcWkRzOyeqdhyk1uOzDypNdjFZbhLrqyWoavq0Ao6 HkvQocBRyX7jwxjErC2roZFr4mQK3z/mOil2Vkb95FSulN+2b+qsSm/06hoY4EoN fWapLcOauKofA2+zTTnp12C0WWEkFVkTIh66O3zG4IGWV7B8DGeiSkbaOm7VuGMN YL8+pI/9yGW6d9JC76tPQipizdiOsorFk2ouakJGb5DCdCl2HSOmjnQjzk1Rb4Kv C04pdzqZcx1pAJfepn/lgLQIYTmNYI6PgJsgQ3NatmRRhV1W9TyIcqIkP8e3axeJ /26U8w6V8UXjBewI8Nme4uSeABuF7/hTVaKUpWzdUI7p30GFkEFpPo8iBOZHyPaI hXITC+Nyp6Fc4uC9zD+PN8K5qIrEWTJ970cDLcwJWYucs0HeH/Nc7bq/Ve8t2wEW //fcPc83CLvfVkNn0tRD =K6Ed -----END PGP SIGNATURE----- --=-=-=--