From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751970AbcC3Kc4 (ORCPT ); Wed, 30 Mar 2016 06:32:56 -0400 Received: from mga11.intel.com ([192.55.52.93]:64499 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbcC3Kcz (ORCPT ); Wed, 30 Mar 2016 06:32:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,415,1455004800"; d="asc'?scan'208";a="921709638" From: Felipe Balbi To: Arnd Bergmann , Greg Kroah-Hartman Cc: Bin Liu , Peter Chen , Arnd Bergmann , Kishon Vijay Abraham I , Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic In-Reply-To: <1458751543-2167046-1-git-send-email-arnd@arndb.de> References: <1458751543-2167046-1-git-send-email-arnd@arndb.de> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 30 Mar 2016 13:31:01 +0300 Message-ID: <871t6sqmu2.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > [ text/plain ] > The phy-am335x driver selects 'USB_COMMON', but all other drivers > use 'depends on' for that symbol, and it depends on USB || USB_GADGET > itself, which causes a Kconfig warning: > > warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct depen= dencies (USB_SUPPORT && (USB || USB_GADGET)) > > As suggested by Felipe Balbi, this turns the logic around, and makes > 'USB_COMMON' selected by everything else that needs it, so we can > remove the dependencies. > > Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for= host-only mode") > Signed-off-by: Arnd Bergmann > Acked-by: Felipe Balbi > Reviewed-by: Peter Chen > --- > I seem to have dropped the ball on this one after my initial submission > when it wasn't clear who should merge the patch. > > Please apply to the USB or the USB gadget tree, whoever gets there > first. seems like this is one of those "can wait for next merge window" right ? I'll take it through my tree. No issues. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW+6rmAAoJEIaOsuA1yqRErMAQAKfBGL45ARHIVZN8d/mMjzMy 63N8jLzarRpBiUfjMyT19WLKznXPuw7e2xS/GBNLbxwtwHD8kCTF71rSXey2OMO2 FCB/1QrMS8+USc+TAUew7DU/DJaLY8yw+qvd4TvH8kw5dGcU/x+2Rl5aJx69NQQN H7D+fmQivV/Y2KkoiwrA9Wk9s7+FW1zYDmUXyMt99uWxi8UyXds+iSZizaroaRXL 0QLc6WojBkEYo/EihYT5YLFA+Y9E9nrYjpjq3XpsQVNLH38kQbCw+D5m3u3Aktbh tFcdBqj0clZQcdbHjoloIxtxJJjFfas+slwbNzqOT791Esz6tRoPyB7i7MUD1aur CZeo3Sg+e2GhwNBTZnpZNw7k9kvd1Rux90QH75DjnAJsVMj3dxlKq3G0u+rqQ5dI iTXS5NS4kZQHma9DfhBWIfZqaCEn+yxpYNm23SP1Iorg6SW1gc4I/8Njlr1tCfx1 voplsQUhNZo2CLKDPX5g4jxoGhstdPmgXYtUDkeLdIcw7eeDcv8N71eATW1nzocV kE+ghe97nh37RvNFuT1eQozsrBch6W6jr74sM3gx2TcaJh8JS+ESqgoZEfhO3scm sfXbHP4azGoVJzL1wjMIReqFYY/ajJ0fpW1TzzlBo/nkPOPk3vPNHh3CjLIRkHtM h1RQMk/C5RZSO9k13JHU =YxQ4 -----END PGP SIGNATURE----- --=-=-=--