Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes

Felipe Balbi
2016-03-07T07:36:09Z

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

Hi,

Felipe Ferreri Tonello <eu@felipetonello.com> writes:
> [ text/plain ]
> Hi Michal,
>
> On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz <mina86@mina86.com> wrote:
>>>> On Wed, Mar 02 2016, Felipe F. Tonello wrote:
>>>>> @@ -16,7 +16,7 @@
>>>>> * Copyright (C) 2006 Thumtronics Pty Ltd.
>>>>> * Ben Williamson <ben.williamson@greyinnovation.com>
>>>>> *
>>>>> - * Licensed under the GPL-2 or later.
>>>>> + * Licensed under the GPLv2.
>>
>>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
>><mina86@mina86.com> wrote:
>>>> Any particular reason to do that?
>>
>>On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote:
>>> Because the kernel is v2 only and not later.
>>
>>Linux as a whole is GPLv2 only, but that doesn’t necessarily mean that
>>parts of it cannot be dual licensed (or GPLv2+). It’s safer to leave
>>copyright noticed clear unless you explicitly want your contribution be
>>GPLv2 only which brings the whole file GPLv2 only.
>>
>>> I just tried to make this driver more consistent with the coding
>>style
>>> used across the kernel. That's it.
>>
>>Column alignment of field names or RHS of assignment operators is quite
>>inconsistent already within drivers/usb/gadget/ which is why I’m
>>concerned whether this is really helping.
>>
>>Anyway, I actually don’t care much, just adding my two rappen.
>
> Right, I am ok with Balbi completely ignoring this patch. But I prefer
> to have at least this driver consistent than nothing. Of course I'll
> remove the license change I made.

consistent in what way ?

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]