Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine

Felipe Ferreri Tonello
2016-03-04T18:39:54Z

Hi Clemens,

On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch <clemens@ladisch.de> wrote:
>Felipe Ferreri Tonello wrote:
>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>> But in what way was the old state machine not "proper"?
>>
>> Because it didn't reflect all the correct and possible MIDI states
>
>The whole point of the one-byte real-time messages is that they do not
>affect the parsing of the surrounding MIDI stream. So not making them
>part of the state machine is the proper way of handling them. (Also
>see the flowchart in appendix A of the spec.)

I really don't get your point. So why do we have a state machine at all?

>
>> This patch doesn't change any functionality. But the important thing
>> here is that it improves the driver maintainability [...]
>
>Then I won't get in the way of this driver's maintainer.

Clemens, I really value your feedback. I just want to understand what's the problem of this patch.

Felipe

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.