From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbcBWOCN (ORCPT ); Tue, 23 Feb 2016 09:02:13 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:33880 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbcBWOCL (ORCPT ); Tue, 23 Feb 2016 09:02:11 -0500 From: Nicolai Stange To: Greg Kroah-Hartman Cc: "Paul E. McKenney" Cc: Alexander Viro Cc: Jonathan Corbet Cc: Jan Kara Cc: Andrew Morton Cc: Julia Lawall Cc: Gilles Muller Cc: Nicolas Palix Cc: Michal Marek Cc: Nicolai Stange Cc: linux-kernel@vger.kernel.org Cc: cocci@systeme.lip6.fr Subject: [PATCH v4 8/8] debugfs: unproxify files created through debugfs_create_u32_array() References: <8737sjo7qa.fsf@gmail.com> Date: Tue, 23 Feb 2016 15:02:07 +0100 In-Reply-To: <8737sjo7qa.fsf@gmail.com> (Nicolai Stange's message of "Tue, 23 Feb 2016 14:51:25 +0100") Message-ID: <871t83mso0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The struct file_operations u32_array_fops associated with files created through debugfs_create_u32_array() has been lifetime aware already: everything needed for subsequent operation is copied to a ->f_private buffer at file opening time in u32_array_open(). Now, ->open() is always protected against file removal issues by the debugfs core. There is no need for the debugfs core to wrap the u32_array_fops with a file lifetime managing proxy. Make debugfs_create_u32_array() create its files in non-proxying operation mode by means of debugfs_create_file_unsafe(). Signed-off-by: Nicolai Stange --- fs/debugfs/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 036ec3f..1a03e99 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -993,7 +993,8 @@ struct dentry *debugfs_create_u32_array(const char *name, umode_t mode, data->array = array; data->elements = elements; - return debugfs_create_file(name, mode, parent, data, &u32_array_fops); + return debugfs_create_file_unsafe(name, mode, parent, data, + &u32_array_fops); } EXPORT_SYMBOL_GPL(debugfs_create_u32_array); -- 2.7.1