From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbcBTSWW (ORCPT ); Sat, 20 Feb 2016 13:22:22 -0500 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:20246 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbcBTSWU (ORCPT ); Sat, 20 Feb 2016 13:22:20 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 20 Feb 2016 19:22:18 +0100 X-ME-IP: 109.222.195.191 From: Robert Jarzmik To: Mark Brown Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec References: <1455979079-9030-1-git-send-email-robert.jarzmik@free.fr> <20160220171459.GA18327@sirena.org.uk> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 20 Feb 2016 19:22:04 +0100 In-Reply-To: <20160220171459.GA18327@sirena.org.uk> (Mark Brown's message of "Sun, 21 Feb 2016 02:14:59 +0900") Message-ID: <871t87z1gz.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown writes: > On Sat, Feb 20, 2016 at 03:37:56PM +0100, Robert Jarzmik wrote: > >> +WM9713 audio CODEC >> + >> +This devices supports I2C. > > No, it clearly doesn't... Right, it supports AC97. > The problem with doing this is that since AC'97 is an enumerable bus we really > shouldn't need to list AC'97 CODECs in the device tree. Ok, I understand that. > Instead we should be probing at runtime (as the non-ASoC AC'97 code does) or > something similar. When you say "non-ASoC AC'97 code", which file are you referring to ? Is it sound/pci/ac97/ac97_codec.c ? If so is there already a table of tuples (AC97_VENDOR_ID1, AC97_VENDOR_ID2) -> (platform device, platform device data) and a matching mechanism already available to the ASoC drivers ? Cheers. -- Robert