From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755527AbcBBQIF (ORCPT ); Tue, 2 Feb 2016 11:08:05 -0500 Received: from icebox.esperi.org.uk ([81.187.191.129]:44432 "EHLO mail.esperi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbcBBQID (ORCPT ); Tue, 2 Feb 2016 11:08:03 -0500 From: Nix To: Thomas Gleixner Cc: Andres Salomon , arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: 4.4.1 regression from 4.1.x: Soekris net5501 crash in IRQ after mfgpt timer initialization References: <87a8njchvj.fsf@esperi.org.uk> <8760y7cfxq.fsf@esperi.org.uk> Emacs: or perhaps you'd prefer Russian Roulette, after all? Date: Tue, 02 Feb 2016 16:07:57 +0000 In-Reply-To: (Thomas Gleixner's message of "Tue, 2 Feb 2016 16:51:38 +0100 (CET)") Message-ID: <871t8vccyq.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: spindle 1282; Body=4 Fuz1=4 Fuz2=4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2 Feb 2016, Thomas Gleixner verbalised: > On Tue, 2 Feb 2016, Nix wrote: >> The fairly trivial code motion below also seems to work, and may be more >> like an actual fix, though I'm a bit horrified that it's this simple. I >> may well have moved too much and unknowingly violated some invariant. > > I was lazy and did not do this, because it wreckages the error pathes. So I > went for the workaround in the hope that the authors of that stuff will take > care :) Oh true. As far as I can tell, getting this right requires a function that reverses the effect of clockevents_config_and_register(), which does not appear to exist yet :( everything else appears more or less reversible... -- NULL && (void)