From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932841AbbFWUoA (ORCPT ); Tue, 23 Jun 2015 16:44:00 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:40043 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910AbbFWUnv (ORCPT ); Tue, 23 Jun 2015 16:43:51 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 23 Jun 2015 22:43:48 +0200 X-ME-IP: 109.222.210.22 From: Robert Jarzmik To: Richard Weinberger Cc: Brian Norris , linux-mtd@lists.infradead.org, dwmw2@infradead.org, maximlevitsky@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0) References: <1433193054-26865-1-git-send-email-richard@nod.at> <1433193054-26865-7-git-send-email-richard@nod.at> <20150617184144.GH4917@ld-irv-0074> <5588FC61.5070202@nod.at> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 23 Jun 2015 22:41:33 +0200 In-Reply-To: <5588FC61.5070202@nod.at> (Richard Weinberger's message of "Tue, 23 Jun 2015 08:27:45 +0200") Message-ID: <871th2kvia.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Richard Weinberger writes: > Am 17.06.2015 um 20:41 schrieb Brian Norris: >> On Mon, Jun 01, 2015 at 11:10:54PM +0200, Richard Weinberger wrote: >>> Don't return a obfuscated null pointer using ERR_PTR(0). >>> If the no device is found clearly return -ENODEV. >>> This makes the code more clear and matches the comment >>> of doc_probe_device(). >>> >>> Signed-off-by: Richard Weinberger >>> --- >> >> Have you tested this patch? > > nah, I don't own such a device. But I do. If you resend a patch, please Cc me. You can even ask for a test from time to time if you want a confirmation, I have a 2 floors docg3 device. Cheers. -- Robert