From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965726AbbDVIxK (ORCPT ); Wed, 22 Apr 2015 04:53:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43649 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965678AbbDVIxD (ORCPT ); Wed, 22 Apr 2015 04:53:03 -0400 From: Vitaly Kuznetsov To: sixiao@microsoft.com Cc: kys@microsoft.com, haiyangz@microsoft.com, devel@linuxdriverproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next, 1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode References: <1429657085-23379-1-git-send-email-sixiao@microsoft.com> Date: Wed, 22 Apr 2015 10:52:57 +0200 In-Reply-To: <1429657085-23379-1-git-send-email-sixiao@microsoft.com> (sixiao@microsoft.com's message of "Tue, 21 Apr 2015 15:58:05 -0700") Message-ID: <871tjcbl3q.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sixiao@microsoft.com writes: > From: Simon Xiao > > Signed-off-by: Simon Xiao > Reviewed-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang I don't quite understand what problem is being solved here (and empty commit message doesn't is not very helpful). netdev_dbg() is not being printed by default and in case if floods logs with too many messages you can change it to net_dbg_ratelimited(). We already have dynamic debug and adding another module parameter shouldn't be needed... > --- > drivers/net/hyperv/hyperv_net.h | 3 +++ > drivers/net/hyperv/netvsc_drv.c | 8 ++++++++ > drivers/net/hyperv/rndis_filter.c | 3 ++- > 3 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h > index a10b316..c9be35e 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -28,6 +28,9 @@ > #include > #include > > +/* flag for netvsc debug mode */ > +extern int debug_mode; > + > /* RSS related */ > #define OID_GEN_RECEIVE_SCALE_CAPABILITIES 0x00010203 /* query only */ > #define OID_GEN_RECEIVE_SCALE_PARAMETERS 0x00010204 /* query and set */ > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index a3a9d38..7c41864 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -52,6 +52,10 @@ static int ring_size = 128; > module_param(ring_size, int, S_IRUGO); > MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)"); > > +int debug_mode = 0; > +module_param(debug_mode, int, S_IRUGO); > +MODULE_PARM_DESC(debug_mode, "debug mode: zero(0) for non-debug mode; non-zero for debug mode"); > + > static void do_set_multicast(struct work_struct *w) > { > struct net_device_context *ndevctx = > @@ -999,6 +1003,10 @@ static int __init netvsc_drv_init(void) > pr_info("Increased ring_size to %d (min allowed)\n", > ring_size); > } > + > + if (debug_mode != 0) > + pr_info("Run netvsc in debug mode"); > + > return vmbus_driver_register(&netvsc_drv); > } > > diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c > index 0d92efe..a3f43f6 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -429,7 +429,8 @@ int rndis_filter_receive(struct hv_device *dev, > > rndis_msg = pkt->data; > > - dump_rndis_message(dev, rndis_msg); > + if (debug_mode != 0) > + dump_rndis_message(dev, rndis_msg); > > switch (rndis_msg->ndis_msg_type) { > case RNDIS_MSG_PACKET: -- Vitaly