Re: [PATCH 3/9] mtd: pxa3xx_nand: set NDCR_PG_PER_BLK if page per block is 128

Boris Brezillon
2015-02-08T20:00:42Z

Hi Antoine,

On Tue, 27 Jan 2015 15:10:10 +0100
Antoine Tenart <antoine.tenart@free-electrons.com> wrote:

I'm not the one who should say that (I'm often sending patches without
any commit message), but a short commit message explaining why you're
doing that would help reviewers ;-).

Best Regards,

Boris

> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/mtd/nand/pxa3xx_nand.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 2681ec4abafa..782ae24d6b7d 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -1216,7 +1216,8 @@ static int pxa3xx_nand_config_flash(struct pxa3xx_nand_info *info,
>
> ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;
> ndcr |= (host->col_addr_cycles == 2) ? NDCR_RA_START : 0;
> - ndcr |= (f->page_per_block == 64) ? NDCR_PG_PER_BLK : 0;
> + ndcr |= (f->page_per_block == 64 || f->page_per_block == 128) ?
> + NDCR_PG_PER_BLK : 0;
> ndcr |= (f->page_size == 2048) ? NDCR_PAGE_SZ : 0;
> ndcr |= (f->flash_width == 16) ? NDCR_DWIDTH_M : 0;
> ndcr |= (f->dfc_width == 16) ? NDCR_DWIDTH_C : 0;

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering