From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933468AbbBBUSO (ORCPT ); Mon, 2 Feb 2015 15:18:14 -0500 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:22379 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbbBBUSM (ORCPT ); Mon, 2 Feb 2015 15:18:12 -0500 X-ME-Helo: beldin X-ME-Date: Mon, 02 Feb 2015 21:18:01 +0100 X-ME-IP: 92.136.77.170 From: Robert Jarzmik To: Stephen Boyd Cc: Mike Turquette , linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: pxa: fix pxa27x_clocks_init scope References: <1422743840-32689-1-git-send-email-robert.jarzmik@free.fr> <54CFD481.7050108@codeaurora.org> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 02 Feb 2015 21:17:58 +0100 In-Reply-To: <54CFD481.7050108@codeaurora.org> (Stephen Boyd's message of "Mon, 02 Feb 2015 11:48:17 -0800") Message-ID: <871tm8awzt.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Boyd writes: > On 01/31/15 14:37, Robert Jarzmik wrote: >> As pxa27x_clocks_init() is called from early boot stage, it has to be >> reachable from pxa architecture code, as are pxa25x_clocks_init() and >> pxa2xx_clock_init(). >> >> Remove the static declaration, which was introduced before the order >> issue between clocks and the timer was discovered (ie. the clocks have >> to be available before the timer, all of this before initcalls are >> called). >> >> Signed-off-by: Robert Jarzmik > > Is this supposed to go through the clk tree? Ah you've got a point, it's a bit embarrassing, see below ... > $ git grep pxa27x_clocks_init > drivers/clk/pxa/clk-pxa27x.c:static int __init pxa27x_clocks_init(void) > drivers/clk/pxa/clk-pxa27x.c:postcore_initcall(pxa27x_clocks_init); > drivers/clk/pxa/clk-pxa27x.c: pxa27x_clocks_init(); > > Where's the early boot stage architecture calling code? It's there : - https://lkml.org/lkml/2015/1/12/1057 - which ended up here in pxa/for-next tree: https://github.com/rjarzmik/linux/commit/a494a74dc52532ed0cef4633db007a08f847a0a8 Which happens to be my tree ... Please forget about this patch, I don't know how I ended up doing this patch ... lack of coffee probably. Cheers. -- Robert