From: "Bjørn Mork" <bjorn@mork.no>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH Resend] cpufreq: remove sysfs files for CPU which failed to come back after resume
Date: Mon, 23 Dec 2013 06:55:56 +0100 [thread overview]
Message-ID: <871u14i00j.fsf@nemi.mork.no> (raw)
In-Reply-To: <1651441.C2UQleWVoy@vostro.rjw.lan> (Rafael J. Wysocki's message of "Sun, 22 Dec 2013 02:00:40 +0100")
"Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
> Bjorn, can you please check if the pm-cpufreq branch of the linux-pm.git tree
> fixes the problem that you have reported
I can confirm that it fixes the major regression. With this branch, the
cpufreq directory is completely removed after a cancelled userspace
hibernate (with the acpi-cpufreq problem causing failure). So it is
possible to restore cpufreq by manually offlining and onlining non-boot
cores. No more leftover sysfs attributes.
But there is still a minor regression compared to the old (v3.11)
behaviour: Previously the cpufreq functionality would be automatically
restored by any completed hibernate or suspend cycle, since it would
effectively do the CPU offline/online. This automatix fixup won't happen
with the current pm-cpufreq branch. User intervention is now required
to fix up cpufreq. Which is expected, due to the special handling of
cpufreq suspend.
So there is still a small, small regression here, making me believe that
my "fix" is better until the cpufreq suspend is properly fixed. But
it's certainly not a major problem to me either way. Your call.
> without causing any new breakage to happen?
I'm not going to guarantee that :-) But I haven't noticed anything
obvious during the 15 minutes I've been testing this branch so far.
Bjørn
next prev parent reply other threads:[~2013-12-23 5:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 15:56 [PATCH Resend] cpufreq: remove sysfs files for CPU which failed to come back after resume Viresh Kumar
2013-12-22 1:00 ` Rafael J. Wysocki
2013-12-23 5:55 ` Bjørn Mork [this message]
2013-12-23 6:02 ` Viresh Kumar
2013-12-23 6:55 ` Bjørn Mork
2013-12-23 7:55 ` viresh kumar
2013-12-23 9:23 ` Bjørn Mork
2013-12-23 10:45 ` Viresh Kumar
2013-12-23 10:57 ` Bjørn Mork
2013-12-23 11:13 ` Viresh Kumar
2013-12-23 11:42 ` Bjørn Mork
2013-12-23 15:45 ` viresh kumar
2013-12-24 0:35 ` Rafael J. Wysocki
2013-12-24 0:27 ` Viresh Kumar
2013-12-24 0:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u14i00j.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox