From: Kevin Hilman <khilman@linaro.org>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: <tony@atomide.com>, <b-cousson@ti.com>,
<linux-omap@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<vaibhav.bedia@ti.com>, <sudhakar.raj@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>, Sekhar Nori <nsekhar@ti.com>,
Alessandro Zummo <a.zummo@towertech.it>,
<rtc-linux@googlegroups.com>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events
Date: Mon, 01 Jul 2013 17:15:01 -0700 [thread overview]
Message-ID: <871u7hom0q.fsf@linaro.org> (raw)
In-Reply-To: <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:08 +0530")
Hebbar Gururaja <gururaja.hebbar@ti.com> writes:
> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
> is available to enable Alarm Wakeup feature. This register needs to be
> properly handled for the rtcwake to work properly.
>
> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt
> compatibility node.
>
> Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: linux-doc@vger.kernel.org
Acked-by: Kevin Hilman <khilman@linaro.org>
...with a minor nit below...
> ---
> :100644 100644 b47aa41... 5a0f02d... M Documentation/devicetree/bindings/rtc/rtc-omap.txt
> :100644 100644 761919d... 666b0c2... M drivers/rtc/rtc-omap.c
> Documentation/devicetree/bindings/rtc/rtc-omap.txt | 6 ++-
> drivers/rtc/rtc-omap.c | 56 +++++++++++++++++---
> 2 files changed, 54 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-omap.txt b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> index b47aa41..5a0f02d 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> @@ -1,7 +1,11 @@
> TI Real Time Clock
>
> Required properties:
> -- compatible: "ti,da830-rtc"
> +- compatible:
> + - "ti,da830-rtc" - for RTC IP used similar to that on DA8xx SoC family.
> + - "ti,am3352-rtc" - for RTC IP used similar to that on AM335x SoC family.
> + This RTC IP has special WAKE-EN Register to enable
> + Wakeup generation for event Alarm.
> - reg: Address range of rtc register set
> - interrupts: rtc timer, alarm interrupts in order
> - interrupt-parent: phandle for the interrupt controller
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 761919d..666b0c2 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -72,6 +72,8 @@
> #define OMAP_RTC_KICK0_REG 0x6c
> #define OMAP_RTC_KICK1_REG 0x70
>
> +#define OMAP_RTC_IRQWAKEEN 0x7C
> +
nit: letters in hex numbers are usually lower-case.
Kevin
next prev parent reply other threads:[~2013-07-02 0:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 9:35 [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Hebbar Gururaja
2013-06-28 9:35 ` [PATCH 1/4] rtc: omap: restore back (hard-code) wakeup support Hebbar Gururaja
2013-07-02 0:06 ` Kevin Hilman
2013-06-28 9:35 ` [PATCH 2/4] davinci: da8xx/omap-l1: Remove hard coding of rtc device wakeup Hebbar Gururaja
2013-06-28 10:14 ` Manjunathappa, Prakash
2013-07-02 0:07 ` Kevin Hilman
2013-07-02 5:20 ` Hebbar, Gururaja
2013-07-02 5:40 ` Sekhar Nori
2013-07-02 5:41 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Hebbar Gururaja
2013-07-02 0:15 ` Kevin Hilman [this message]
2013-07-02 5:20 ` Hebbar, Gururaja
2013-07-02 6:02 ` Sekhar Nori
2013-07-02 6:04 ` Hebbar, Gururaja
2013-07-02 6:09 ` Sekhar Nori
2013-07-02 6:11 ` Hebbar, Gururaja
2013-07-02 6:16 ` Sekhar Nori
2013-07-03 5:03 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility Hebbar Gururaja
2013-07-02 6:12 ` Sekhar Nori
2013-07-02 6:14 ` Hebbar, Gururaja
2013-07-02 6:19 ` Hebbar, Gururaja
2013-07-03 8:12 ` Sekhar Nori
2013-07-02 0:18 ` [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u7hom0q.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=a.zummo@towertech.it \
--cc=b-cousson@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=sudhakar.raj@ti.com \
--cc=tony@atomide.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox