Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface

["Bjørn Mork" <bjorn@mork.no>]

Schmiedl Christian <Christian.Schmiedl@gemalto.com> writes:

> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface
> by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and
> WWAN Interface Number.

Much better.  But this patch need to go to the netdev list to get picked
up by the net patchworks and maintainer.  It was posted there the last
time, so I don't understand why you dropped that now?  The minimum To/Cc
list for usbnet drivers is:

 netdev@vger.kernel.org, linux-usb@vger.kernel.org

Anything else is a bonus, and adding linux-kernel is of course fine.
Hint:  Use linux/scripts/get_maintainer.pl to get a list of addresses to
send a patch to.

> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
> Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>

This is of course fine, but the patch was sent by Hans-Christoph the
last time.  If he is the original author, then you also want to preserve
that authorship in the git history (in addition to those SOBs).  The
proper way to do that is to add a line like this as the first line of
the email body, followed by a single empty line:

From: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>

This will make "git am" use Hans-Christoph as the author, even if the
patch is posted by you.

And since you obviously have to resend this anyway: Please drop the file
name ("/drivers/net/usb/qmi_wwan.c: ") from the commit message.  It is
part of the patch itself, and including it in the commit message just
adds noise.


Thanks,
Bjørn