From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arvid Brodin <Arvid.Brodin@xdin.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Cyrill Gorcunov <gorcunov@openvz.org>,
"David Rientjes" <rientjes@google.com>
Subject: Re: [PATCH] fs/proc: Add process text segment md5-summing
Date: Mon, 12 Nov 2012 18:16:03 -0800 [thread overview]
Message-ID: <871ufyjli4.fsf@xmission.com> (raw)
In-Reply-To: <20121112150325.2516a0bf.akpm@linux-foundation.org> (Andrew Morton's message of "Mon, 12 Nov 2012 15:03:25 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Mon, 12 Nov 2012 21:36:17 +0000
> Arvid Brodin <Arvid.Brodin@xdin.com> wrote:
>
>> Adds /proc/<pid>/text_md5sum which, when read, calculates an md5sum over
>> the process' text segment. This can detect some cases where the system RAM
>> has been disturbed by e.g. ESD or cosmic radiation (on systems where ECC
>> is not available). It might also detect some accidental or malicious
>> modifications of executables, where the perpetrator has not bothered to
>> cover up the tracks.
>
> I thought the review comments regarding the earlier patch were rather
> fatal, sorry.
To add another nail in the coffin.
You can do this with ptrace or with /proc/<pid>/mem without a kernel
patch.
To make this safe would need a ptrace_may_acces(PTRACE_MODE_READ)
permission check. At which point not doing this with ptrace just adds
up to extra kernel maintenance for no real point.
Eric
next prev parent reply other threads:[~2012-11-13 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:36 [PATCH] fs/proc: Add process text segment md5-summing Arvid Brodin
2012-11-12 23:03 ` Andrew Morton
2012-11-13 2:16 ` Eric W. Biederman [this message]
2012-11-14 1:45 ` Arvid Brodin
2012-11-14 0:11 ` Arvid Brodin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ufyjli4.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=Arvid.Brodin@xdin.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox