From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242Ab2DRX7a (ORCPT ); Wed, 18 Apr 2012 19:59:30 -0400 Received: from void.printf.net ([89.145.121.20]:56397 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605Ab2DRX73 (ORCPT ); Wed, 18 Apr 2012 19:59:29 -0400 From: Chris Ball To: Guennadi Liakhovetski Cc: H Hartley Sweeten , Linux Kernel , linux-mmc@vger.kernel.org, svenkatr@ti.com Subject: Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes References: <201204171303.39744.hartleys@visionengravers.com> Date: Wed, 18 Apr 2012 19:59:39 -0400 In-Reply-To: (Guennadi Liakhovetski's message of "Tue, 17 Apr 2012 22:31:17 +0200 (CEST)") Message-ID: <871unkmw0k.fsf@laptop.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Apr 17 2012, Guennadi Liakhovetski wrote: > On Tue, 17 Apr 2012, H Hartley Sweeten wrote: > >> Include the linux/mmc/cd-gpio.h header to pickup the prototypes >> for the two exported symbols. >> >> This quiets the sparse warnings: >> >> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static? >> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static? >> >> Signed-off-by: H Hartley Sweeten >> Cc: Chris Ball >> Cc: Guennadi Liakhovetski >> Acked-by: Venkatraman S > > Acked-by: Guennadi Liakhovetski Thanks, pushed to mmc-next for 3.4. - Chris. -- Chris Ball One Laptop Per Child