* [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes
@ 2012-04-17 20:03 H Hartley Sweeten
2012-04-17 20:31 ` Guennadi Liakhovetski
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2012-04-17 20:03 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-mmc, cjb, g.liakhovetski, svenkatr
Include the linux/mmc/cd-gpio.h header to pickup the prototypes
for the two exported symbols.
This quiets the sparse warnings:
warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Venkatraman S <svenkatr@ti.com>
---
v2: add new header alphabetically
diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
index 29de31e..2c14be7 100644
--- a/drivers/mmc/core/cd-gpio.c
+++ b/drivers/mmc/core/cd-gpio.c
@@ -12,6 +12,7 @@
#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/jiffies.h>
+#include <linux/mmc/cd-gpio.h>
#include <linux/mmc/host.h>
#include <linux/module.h>
#include <linux/slab.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes
2012-04-17 20:03 [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes H Hartley Sweeten
@ 2012-04-17 20:31 ` Guennadi Liakhovetski
2012-04-18 23:59 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Guennadi Liakhovetski @ 2012-04-17 20:31 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-mmc, cjb, svenkatr
On Tue, 17 Apr 2012, H Hartley Sweeten wrote:
> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
> for the two exported symbols.
>
> This quiets the sparse warnings:
>
> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Acked-by: Venkatraman S <svenkatr@ti.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
>
> ---
>
> v2: add new header alphabetically
>
> diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
> index 29de31e..2c14be7 100644
> --- a/drivers/mmc/core/cd-gpio.c
> +++ b/drivers/mmc/core/cd-gpio.c
> @@ -12,6 +12,7 @@
> #include <linux/gpio.h>
> #include <linux/interrupt.h>
> #include <linux/jiffies.h>
> +#include <linux/mmc/cd-gpio.h>
> #include <linux/mmc/host.h>
> #include <linux/module.h>
> #include <linux/slab.h>
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes
2012-04-17 20:31 ` Guennadi Liakhovetski
@ 2012-04-18 23:59 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-04-18 23:59 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: H Hartley Sweeten, Linux Kernel, linux-mmc, svenkatr
Hi,
On Tue, Apr 17 2012, Guennadi Liakhovetski wrote:
> On Tue, 17 Apr 2012, H Hartley Sweeten wrote:
>
>> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
>> for the two exported symbols.
>>
>> This quiets the sparse warnings:
>>
>> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
>> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Chris Ball <cjb@laptop.org>
>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> Acked-by: Venkatraman S <svenkatr@ti.com>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-18 23:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 20:03 [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes H Hartley Sweeten
2012-04-17 20:31 ` Guennadi Liakhovetski
2012-04-18 23:59 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox