From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757511Ab1I2Tfr (ORCPT ); Thu, 29 Sep 2011 15:35:47 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:57334 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290Ab1I2Tfq (ORCPT ); Thu, 29 Sep 2011 15:35:46 -0400 From: OGAWA Hirofumi To: Joe Perches Cc: Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCHv4] fat: don't use custom hex_to_bin() References: <87ipob8l4l.fsf@devron.myhome.or.jp> <1317310634.1854.25.camel@Joe-Laptop> <8762kb8aqj.fsf@devron.myhome.or.jp> <1317321707.1867.1.camel@Joe-Laptop> Date: Fri, 30 Sep 2011 04:35:43 +0900 In-Reply-To: <1317321707.1867.1.camel@Joe-Laptop> (Joe Perches's message of "Thu, 29 Sep 2011 11:41:47 -0700") Message-ID: <871uuz87lc.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: >> > perhaps: >> > >> > __le16 foo; >> > >> > if (hex2bin((u8 *)&foo, ip + 1, 2) < 0) >> > return -EINVAL; >> > *(u16 *)op = le16_to_cpu(foo); >> > >> > op += 2; >> >> I also thought about it. But I think it is not so good, like you had >> mistake. It should actually be "__be16 foo" and "be16_to_cpu()". >> >> If we used sscanf() instead of hex2bin(), I might agree to use >> "le16_to_cpu()" though. >> >> Thanks. > > Funny. > > I guess that's what I get for reading Andy's comment > and coding that readably. > > + /* The ip contains 2 bytes in little > + * endian format. We need to get them > + * in native endian. */ In here, simply comment is wrong. Thanks. -- OGAWA Hirofumi