public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Avishay Traeger <avishay@il.ibm.com>,
	linux-kernel@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] virtio_blk: add block topology support
Date: Sat, 30 Jul 2011 14:22:42 +0930	[thread overview]
Message-ID: <871ux84bfp.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAB9v_DH1Y6B3mOMR=6Tgc3WYXXtgS4FEoUntNSt97mtqpQ8qyA@mail.gmail.com>

On Fri, 29 Jul 2011 22:09:49 +0300, Alexey Zaytsev <alexey.zaytsev@gmail.com> wrote:
> VIRTIO_BLK_F_TOPOLOGY and VIRTIO_BLK_F_SECTOR_MAX features use the
> same bit, don't they?

Yes, spec bug.

> I guess you could just remove VIRTIO_BLK_F_SECTOR_MAX from the spec.
> Linux did not implement it, and virtualbox does not have virtio block
> support at all. Are there any other known users, who might have
> implemented the  VIRTIO_BLK_F_SECTOR_MAX feature?

Did qemu implement it?  If not, we'll simply kill it, and pretend it
never happened...

Thanks,
Rusty.

  reply	other threads:[~2011-07-30  5:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 19:01 [PATCH] virtio_blk: add block topology support Christoph Hellwig
2010-01-30  4:59 ` Rusty Russell
2010-01-30 20:19   ` Christoph Hellwig
2010-02-01  1:10     ` Rusty Russell
2011-07-14 23:36       ` Alexey Zaytsev
2011-07-21  7:53         ` Rusty Russell
2011-07-29 19:09           ` Alexey Zaytsev
2011-07-30  4:52             ` Rusty Russell [this message]
2011-07-31 18:19               ` Christoph Hellwig
2011-08-01  5:22                 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ux84bfp.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=alexey.zaytsev@gmail.com \
    --cc=avi@redhat.com \
    --cc=avishay@il.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox