* [PATCH V2] fs/9p: Use updated offset for writing
@ 2011-03-16 16:10 M. Mohan Kumar
2011-03-20 13:56 ` Aneesh Kumar K. V
0 siblings, 1 reply; 3+ messages in thread
From: M. Mohan Kumar @ 2011-03-16 16:10 UTC (permalink / raw)
To: v9fs-developer, aneesh.kumar; +Cc: linux-fsdevel, linux-kernel
Use the updated offset given by generic_write_checks. Without this fix,
even if a file is opened in O_APPEND mode, data will be written at current
file position instead of end of file.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
fs/9p/vfs_file.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 6997eb6..ffed558 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -508,9 +508,12 @@ v9fs_file_write(struct file *filp, const char __user * data,
if (!count)
goto out;
- return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
+ retval = v9fs_file_write_internal(filp->f_path.dentry->d_inode,
filp->private_data,
- data, count, offset, 1);
+ data, count, &origin, 1);
+ /* update offset on successful write */
+ if (retval > 0)
+ *offset = origin;
out:
return retval;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] fs/9p: Use updated offset for writing
2011-03-16 16:10 [PATCH V2] fs/9p: Use updated offset for writing M. Mohan Kumar
@ 2011-03-20 13:56 ` Aneesh Kumar K. V
2011-03-20 17:59 ` [V9fs-developer] " Eric Van Hensbergen
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K. V @ 2011-03-20 13:56 UTC (permalink / raw)
To: M. Mohan Kumar, v9fs-developer; +Cc: linux-fsdevel, linux-kernel
On Wed, 16 Mar 2011 21:40:49 +0530, "M. Mohan Kumar" <mohan@in.ibm.com> wrote:
> Use the updated offset given by generic_write_checks. Without this fix,
> even if a file is opened in O_APPEND mode, data will be written at current
> file position instead of end of file.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Eric,
I guess this should go in this merge window ?
> ---
> fs/9p/vfs_file.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 6997eb6..ffed558 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -508,9 +508,12 @@ v9fs_file_write(struct file *filp, const char __user * data,
> if (!count)
> goto out;
>
> - return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> + retval = v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> filp->private_data,
> - data, count, offset, 1);
> + data, count, &origin, 1);
> + /* update offset on successful write */
> + if (retval > 0)
> + *offset = origin;
> out:
> return retval;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [V9fs-developer] [PATCH V2] fs/9p: Use updated offset for writing
2011-03-20 13:56 ` Aneesh Kumar K. V
@ 2011-03-20 17:59 ` Eric Van Hensbergen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Van Hensbergen @ 2011-03-20 17:59 UTC (permalink / raw)
To: Aneesh Kumar K. V
Cc: M. Mohan Kumar, v9fs-developer, linux-fsdevel, linux-kernel
Yeah, probably a good idea, if we don't make it in time these are
actually fixes so we can bring them in during -rc1.
On Sun, Mar 20, 2011 at 8:56 AM, Aneesh Kumar K. V
<aneesh.kumar@linux.vnet.ibm.com> wrote:
> On Wed, 16 Mar 2011 21:40:49 +0530, "M. Mohan Kumar" <mohan@in.ibm.com> wrote:
>> Use the updated offset given by generic_write_checks. Without this fix,
>> even if a file is opened in O_APPEND mode, data will be written at current
>> file position instead of end of file.
>>
>> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> Eric,
>
> I guess this should go in this merge window ?
>
>> ---
>> fs/9p/vfs_file.c | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
>> index 6997eb6..ffed558 100644
>> --- a/fs/9p/vfs_file.c
>> +++ b/fs/9p/vfs_file.c
>> @@ -508,9 +508,12 @@ v9fs_file_write(struct file *filp, const char __user * data,
>> if (!count)
>> goto out;
>>
>> - return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
>> + retval = v9fs_file_write_internal(filp->f_path.dentry->d_inode,
>> filp->private_data,
>> - data, count, offset, 1);
>> + data, count, &origin, 1);
>> + /* update offset on successful write */
>> + if (retval > 0)
>> + *offset = origin;
>> out:
>> return retval;
>> }
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-20 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-16 16:10 [PATCH V2] fs/9p: Use updated offset for writing M. Mohan Kumar
2011-03-20 13:56 ` Aneesh Kumar K. V
2011-03-20 17:59 ` [V9fs-developer] " Eric Van Hensbergen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).