From: Andi Kleen <andi@firstfloor.org>
To: Patrick Pannuto <ppannuto@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, sboyd@codeaurora.org,
tglx@linutronix.de, mingo@elte.hu, heiko.carstens@de.ibm.com,
eranian@google.com, schwidefsky@de.ibm.com
Subject: Re: [RFC] [PATCH] timer: Added usleep[_range][_interruptable] timer
Date: Thu, 24 Jun 2010 12:22:41 +0200 [thread overview]
Message-ID: <871vbwafwu.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4C225EED.5040600@codeaurora.org> (Patrick Pannuto's message of "Wed, 23 Jun 2010 12:22:21 -0700")
Patrick Pannuto <ppannuto@codeaurora.org> writes:
Overall it seems like a good improvement.
> +
> +static inline void usleep(unsigned long usecs)
> +{
> + usleep_range(usecs, usecs);
> +}
> +
> +static inline unsigned long usleep_interruptible(unsigned long usecs)
Is the interruptible case even needed? I assume most drivers won't
bother with that and not being interruptible for a few usecs is not a
big issue.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-24 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 19:22 [RFC] [PATCH] timer: Added usleep[_range][_interruptable] timer Patrick Pannuto
2010-06-23 20:05 ` Daniel Walker
2010-06-23 20:21 ` Patrick Pannuto
2010-06-23 20:56 ` Daniel Walker
2010-06-23 22:04 ` Andreas Mohr
2010-06-26 21:43 ` Pavel Machek
2010-06-28 18:03 ` Patrick Pannuto
2010-06-28 19:39 ` Daniel Walker
2010-06-24 10:22 ` Andi Kleen [this message]
2010-06-24 16:51 ` Patrick Pannuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vbwafwu.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ppannuto@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox