Re: [PATCH] x86: default to reboot via ACPI

Pavel Machek
2008-08-26T09:59:18Z

On Mon 2008-08-25 13:11:27, Avi Kivity wrote:
> Triple-fault and keyboard reset may assert INIT instead of RESET; however
> INIT is blocked when Intel VT is enabled. This leads to a partially reset
> machine when invoking emergency_restart via sysrq-b: the processor is still
> working but other parts of the system are dead.
>
> Default to rebooting via ACPI, which correctly asserts RESET and reboots the
> machine.
>
> This is safe since we will fall back to keyboard reset and triple fault if
> acpi is not enabled or if the reset is not successful.
>
> Signed-off-by: Avi Kivity <avi@qumranet.com>

"ACPI" and "safe" in one sentence. /me bets this will break lot of
machines.

What about only doing that when enabling VT?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html