From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941195AbcIHPXZ (ORCPT ); Thu, 8 Sep 2016 11:23:25 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36664 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941159AbcIHPXX (ORCPT ); Thu, 8 Sep 2016 11:23:23 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-omap@vger.kernel.org From: Thiago Jung Bauermann To: Russell King - ARM Linux Cc: Tony Lindgren , Andrew Morton , Eric Biederman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Dave Young , Mimi Zohar , linux-ima-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org Subject: Re: Kexec regression in next-20160906 Date: Thu, 08 Sep 2016 12:23:13 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-95-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160907080807.GD5783@n2100.arm.linux.org.uk> References: <20160906220936.4txqzodkgknhjiyh@atomide.com> <2229914.bQjEFCIRgO@hactar> <20160907080807.GD5783@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090815-0032-0000-0000-000002825BF7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090815-0033-0000-0000-00000ED8A034 Message-Id: <8729269.3rIvqbaU1r@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609080225 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 07 September 2016, 09:08:07 schrieb Russell King - ARM Linux: > Any change to a UAPI header needs to be carefully considered and > questioned as it is always a potential userspace breakage - and in > the kernel, we're supposed to be doing our up-most to avoid > breaking userspace. > > It's not like it was in the old days when we didn't have the UAPI > seperate - today, we can find these things by looking at the patch > diffstat and seeing whether any file in "uapi" is touched. That > should be the trigger for a really in-depth review of the change. No UAPI header is touched by this patch series. That is because there are two definitions of struct kexec_segment, one in include/linux/kexec.h and the other one in include/uapi/linux/kexec.h. My patch changed the former. I was unaware of the second definition in the latter. -- []'s Thiago Jung Bauermann IBM Linux Technology Center