From: Steven Price <steven.price@arm.com>
To: Zou Wei <zou_wei@huawei.com>,
robh@kernel.org, tomeu.vizoso@collabora.com,
alyssa.rosenzweig@collabora.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/panfrost: Fix unused variable warning
Date: Mon, 2 Nov 2020 09:29:08 +0000 [thread overview]
Message-ID: <8729ad8d-31db-c7cd-e962-a0f7db6891b3@arm.com> (raw)
In-Reply-To: <1604309599-10078-1-git-send-email-zou_wei@huawei.com>
On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
>
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
> struct panfrost_job_slot *js = pfdev->js;
> ^~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Boris posted an identical patch earlier:
https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>
> void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
> {
> - struct panfrost_device *pfdev = panfrost_priv->pfdev;
> - struct panfrost_job_slot *js = pfdev->js;
> int i;
>
> for (i = 0; i < NUM_JOB_SLOTS; i++)
>
next prev parent reply other threads:[~2020-11-02 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 9:33 [PATCH -next] drm/panfrost: Fix unused variable warning Zou Wei
2020-11-02 9:29 ` Steven Price [this message]
2020-11-02 11:54 ` 答复: " Zouwei (Samuel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8729ad8d-31db-c7cd-e962-a0f7db6891b3@arm.com \
--to=steven.price@arm.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).