From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDA6C388F2 for ; Mon, 2 Nov 2020 09:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2D162223C for ; Mon, 2 Nov 2020 09:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbgKBJ3N (ORCPT ); Mon, 2 Nov 2020 04:29:13 -0500 Received: from foss.arm.com ([217.140.110.172]:56568 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbgKBJ3M (ORCPT ); Mon, 2 Nov 2020 04:29:12 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C476101E; Mon, 2 Nov 2020 01:29:12 -0800 (PST) Received: from [192.168.1.79] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AC263F718; Mon, 2 Nov 2020 01:29:10 -0800 (PST) Subject: Re: [PATCH -next] drm/panfrost: Fix unused variable warning To: Zou Wei , robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1604309599-10078-1-git-send-email-zou_wei@huawei.com> From: Steven Price Message-ID: <8729ad8d-31db-c7cd-e962-a0f7db6891b3@arm.com> Date: Mon, 2 Nov 2020 09:29:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1604309599-10078-1-git-send-email-zou_wei@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2020 09:33, Zou Wei wrote: > Fixes the following W=1 kernel build warning: > > ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable] > struct panfrost_job_slot *js = pfdev->js; > ^~ > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Boris posted an identical patch earlier: https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com Steve > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 4902bc6..e75b7d2 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv) > > void panfrost_job_close(struct panfrost_file_priv *panfrost_priv) > { > - struct panfrost_device *pfdev = panfrost_priv->pfdev; > - struct panfrost_job_slot *js = pfdev->js; > int i; > > for (i = 0; i < NUM_JOB_SLOTS; i++) >