From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E1C204C3B for ; Wed, 22 Jul 2026 12:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784725006; cv=none; b=kfWi4rS38Nifj3BtYNr6cFBulAnp1nf9DFbDXRKjKxS9PsgdES3plQXa3yqirDglXxTACdY52VevUlV2AUotHfh7vtHtHrl3iCVRAtEo5duFake45nVPg6LlNwQ28wGQN2zMNrmiVUwWyg+Y4jxKfOG3kAFBhCsKzVY8Y93Io8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784725006; c=relaxed/simple; bh=ulq1BAsh4vcS9IgVnh9uk0btSVio2++zWwkHAVFyhNQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=K6E0uaw52FAALtSPUK5S9emGmRXAXMyDfhumQXbrC+lTvXYSc0AnxbanI+rAKScgsFQaYjkbnTGBJtpD+SPh2LMLS3FQZ78FWjnJzhTQTNhZpwnTbnV3sMZrfzdWwCaHIhxjQ8ayNXoDK7FZrmD/9PLCw7wBIKCZp9HHaaHQ+wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KVUh2rsY; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KVUh2rsY" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 814504E40ECB; Wed, 22 Jul 2026 12:56:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 562CB60388; Wed, 22 Jul 2026 12:56:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7AEB011BD3B59; Wed, 22 Jul 2026 14:56:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1784725001; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ulq1BAsh4vcS9IgVnh9uk0btSVio2++zWwkHAVFyhNQ=; b=KVUh2rsYXVJ8RUy/2o0vSko+utGIJMbHMA+3jEzihmJfOLzkPJ4xhYkTxKYvzGFwi1l3+6 SP6Ig+fTDRp7VLGaZW28qDnUjblhF0Srz5Dw5YN1LkbE6raNJNOI5TqD+UqjgGvlP0AZWP AZkBJx2oIr2fPJfFgR+sRQrhJVTFzEutajERjHBDtXdGhNJgwiyE3WqPGn1Ybomke4xK4p +prFsZ1qYEQX6/KYGjpgFxgrIPSO19qja5oDRBBqJieN++OqSgvL67ieC8/I8iwD7sdN0Y ld1B9e+0c9Rr3F+BUv8marqOhQvwPENoPyXzCSNLLw3Z5hIlVz3qsXS6hFWFyg== From: Miquel Raynal To: "Michael Walle" Cc: "Pratyush Yadav" , "Takahiro Kuwano" , "Richard Weinberger" , "Vignesh Raghavendra" , "Thomas Petazzoni" , "Steam Lin" , , Subject: Re: [PATCH 03/30] mtd: spi-nor: winbond: Stop filling the .name entry In-Reply-To: (Michael Walle's message of "Mon, 06 Jul 2026 15:59:53 +0200") References: <20260529-winbond-v7-1-spi-nor-jv-cleanup-v1-0-87e5d3122244@bootlin.com> <20260529-winbond-v7-1-spi-nor-jv-cleanup-v1-3-87e5d3122244@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 22 Jul 2026 14:56:39 +0200 Message-ID: <8733xbji7s.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 06/07/2026 at 15:59:53 +02, "Michael Walle" wrote: > On Fri May 29, 2026 at 5:22 PM CEST, Miquel Raynal wrote: >> This is a legacy field, it is often incorrectly filled and will soon >> become very incorrect due to IDs being reused. > > And I thought winbond is doing better... So if you have a contact > there, please suggest they are putting a table with a unique > identifier per chip there. So we can use that to do fixups. Yes, this is something that has been raised, I can confirm. We found a way through the SFDP data to reliably identify which chip it is since the SFDP version has been reliably updated over time (see the RV and PW addition patches). >> Replace the names with a comment above the entry with the newly instated >> naming scheme to indicate what chips are covered by each entry. > > This is exported via sysfs, so this could be a regression. > > Not sure.. Yes, but the names are totally wrong. And become even wronger with the addition of the RV, PW, etc families. I was already asked to not put a name on the new additions, I believe we should drop those fields, they are very misleading. So what is your final position? Pratyush any feedback? I can keep the old names, but, well, you know my position, they are wrong and old. Thanks for the feedback by the way! Miqu=C3=A8l