From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A822F12A5; Tue, 7 Jul 2026 06:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783405892; cv=none; b=hpuK5K8N+EXmbF2mX6g7HjSrwpjNuKV5IIQsdey6oG1mRV1Yz9pKU8F9sSke8mwB5oJ6sAfL/LQFjU6de7H6Kk06r2THVmXLDZzo3B2x1SpyWbRJ8UtEJ8ASm8i/SgZviIB75INW7u2IcI5tSFHbsw1FasdLsXLwKHCh+Eae1wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783405892; c=relaxed/simple; bh=yjK+MgNVUSfwz13f78upz7ONpUxHIMfFE1ju5M2QNYM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NBjBt5ANfM/YmHgiSC90NRwNn8iscdfdFBIyV3kmPB3A4HGRQCYjuEakaDTMrc23lPTkG/m4NzfAlC81oFpHiWcq5L9JmQUV3O9pX9HHURIVJYKc8TdarpyfXHORIZyVZPD1Y2VHzw5iwRFkCIRHysCRPZnnv2tCX3P1Vb2mAaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=czWmUPtb; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="czWmUPtb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 24CB04E40CC6; Tue, 7 Jul 2026 06:31:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EB227601A3; Tue, 7 Jul 2026 06:31:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 194B511BC07A4; Tue, 7 Jul 2026 08:31:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783405881; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=yjK+MgNVUSfwz13f78upz7ONpUxHIMfFE1ju5M2QNYM=; b=czWmUPtbmR23diM2cnPh2/18t5+ILy9oG37sriIJzI4QxsMJyX9JXukEophqNNei0q2oJq 1kObrXzJ8LIg6SZSju2tsOPI0JL8izPaitQVm6rEw2JyaBCoUc2gOYJ/AkgIOsRgmkaaZc UUwsMicirwnvMRbJNp3H2Rr+gmH2adapoBl3pn16i5wPpJfcRxuZY3R3afvCI5nDm2jfIm TdXOTvCYSOdHpPzcEJOs3aY43uZBjP036/fB2HD6odYC/erEqSgPONHyljdBqZ9+eWJ8uy VdIwyVdspXTVraprOLKY40pUJoOplWh0TNOVLmvdpr9AJsmSfp5QXZudBoEizw== From: Miquel Raynal To: Krzysztof Kozlowski Cc: Manivannan Sadhasivam , Stephan Gerhold , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 In-Reply-To: <47bd85c0-f015-4c43-b616-c249596d7537@kernel.org> (Krzysztof Kozlowski's message of "Mon, 6 Jul 2026 18:18:15 +0200") References: <20260608-qcom-nandc-mdm9607-v1-0-4639a0492274@linaro.org> <4kdjxrn3bxg7rhkdovidxv2b2f6evnknng7gjtbz7pahyqaakh@qkgxaz6xlav2> <875x2smf39.fsf@bootlin.com> <87y0foji2a.fsf@bootlin.com> <47bd85c0-f015-4c43-b616-c249596d7537@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 07 Jul 2026 08:31:15 +0200 Message-ID: <8733xvjop8.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 06/07/2026 at 18:18:15 +02, Krzysztof Kozlowski wrote: > On 06/07/2026 18:00, Manivannan Sadhasivam wrote: >> On Mon, Jul 06, 2026 at 04:42:21PM +0200, Miquel Raynal wrote: >>=20 >>>> and if the driver queries the frequency of >>>> RPM_SMD_QPIC_CLK, it would just return the same frequency. This is whe= re the >>>> dummy clock comes handy as it atleast provides a valid clock frequency= to the >>>> driver. But I'm not advocating for its usage here anymore. >>>> >>>> Hence IMO, assigning the same RPM_SMD_QPIC_CLK to all 3 clocks is not = the right >>>> approach and we should be assigning a single RPM_SMD_QPIC_CLK to >>>> 'core' clk. >>> >>> You said using three times the same clock would be wrong because we >>> would get three times the same rate whereas in practice it's wrong. This >>> means the OS has access to these clocks somehow, >>=20 >> No, there is no way the OS can access these 3 clocks individually on the= RPMh >> enabled platforms. But the OS indeed has access to these 3 clocks on non= -RPMh >> platforms like the older IPQ ones. > > I think RPMh is a bit different case than recently discussed SCMI > firmware layer, although maybe the true difference is irrelevant - > whoever implements the clock handling, it is not Linux. Anyway, in case > of SCMI this is the same die having either firmware or OS controlling > clocks. > > Here the SoCs (IPO ones without RPMh and this one with RPMh) are differen= t. > > If this was some bus device (I2C, SPI etc), then I would argue that the > device pins matter. > > However this is internal part of the SoC, so while it still has some > wirings, they are heavily hidden or abstracted, thus I am fine with > approach that clocks represent the clock interfaces available to the OS, > not the physical wires inside SoC. Thank you very much for this feedback. I understand the rationale, and will keep that in mind for future reviews. Best regards, Miqu=C3=A8l