From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED0193C585C for ; Tue, 30 Jun 2026 16:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782837745; cv=none; b=VnD0T+zWpjt2SW9s7ToPhlWTn8kz15MbZjNjjwEhcp/iuxx59d4FWkASnhYAaO6BpdYEfRdf9tvKal7I5PmwKRiv9QlOO/0QOkrbMbbK4e4tn7mJfduzk1iEckjQ8TXvqKwR6FZMbib/plAOHqibAUuM4l+X9FWJIQ6O02SiHrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782837745; c=relaxed/simple; bh=7935vxdEENre2njdS5MHhz9n4M3JQ0ueZvpzmZx0Dn8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ROVsOzbWmVciLZGoL3DPT9JHeABaTwEWsiu0Kmxuk2ID884oR5kdDP8qYbdW92bHyFeezrr2rgNGNDZxVyc2m3eC1K5gLAxKVvwB7bmsI4nZHe+rHq0RQX3dCDGEL9bzCuScYW0RdMxsP3pQgil/ne4oZD+WjrOABH5bOxS3jDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wb7kkpU8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wb7kkpU8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B151C1F000E9; Tue, 30 Jun 2026 16:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782837744; bh=7935vxdEENre2njdS5MHhz9n4M3JQ0ueZvpzmZx0Dn8=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Wb7kkpU882iEL8yZLdT7N2A0Yt8Z6dYqACWKj6KNrWC2UseK1Vb0Y6rpfwN27xlqX Fyejpb1vH7RmqTgWliAMLZ+srJPSy0yF76QCUpkGA8m0VwDXRehuTBrPgXee1usYyn BCuECVd5mpkK0f4tlLzGM7pvZGefMhU/PxXSDTw+dw8/jGK84PT2LcLfzT06UIq7wK YD0LLpJj7TD66UbpjBM+LpFThrOIf1TqJjUCCtmFrjswpcs4ao9NZqnLBXd2YQU3mX zUP/3TWSGGCL/zxmWWp80NOV5PnLM0MwVi023nDQuvig3iV6VvM2bqMete6ZYHrJ0M IDXhJVufVeZDg== From: Thomas Gleixner To: Kemeng Shi , maz@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: Re: [PATCH v3 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() In-Reply-To: <20260623020135.3584-4-shikemeng@huaweicloud.com> References: <20260623020135.3584-1-shikemeng@huaweicloud.com> <20260623020135.3584-4-shikemeng@huaweicloud.com> Date: Tue, 30 Jun 2026 18:42:21 +0200 Message-ID: <8733y4q8sy.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jun 23 2026 at 10:01, Kemeng Shi wrote: > We miss to teardown the vpe when its_irq_gic_domain_alloc() is failed. We miss nothing. Change logs want to be written in passive voice. It's documented. > Just fix this. 'Just fix this' tells nothing and is just a sloppy pointless phrase. Lacks a Fixes: tag as well