From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A28E23DB307 for ; Tue, 19 May 2026 17:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779211010; cv=none; b=ibiDRZaPzdvhYyQzo8p+FDz3OaM44FZySIWJRK7XKSNMp8w7ytlJrTDxwLTeRyMAQcv/dTFaeHk/XjcJhcO1WsXvw97tOH0Ps5TEYBlzrYPVCZjKYZQMRi+dlahVuqqU9YGNFPhvM6RN/XUaMupM22eTStoV9kwUUyfuK96gHD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779211010; c=relaxed/simple; bh=g+Udg1tEeap8aR3K8wRu7qLjPHm00TPKV/hnM/+ENEM=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=dgKeULbMdocMfl8kXODWkXD72x2y40Kd6Lcx1i2p2+f0yUEyI15I0oN0HABbsKlmWqZ1STGbHx/cW5lUHgD3YZmtYCYzev3PBHlja/fEIf2HDjz0uUyx5kS/3foxCL61nERJYSKu54l2TLQR6nT8xsVOOUq3VTsWTvT1fV8G+3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hbQzz2y8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hbQzz2y8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804BDC2BCB3; Tue, 19 May 2026 17:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779211010; bh=g+Udg1tEeap8aR3K8wRu7qLjPHm00TPKV/hnM/+ENEM=; h=From:To:Subject:In-Reply-To:References:Date:From; b=hbQzz2y8W1OQfanh+mKJxBdH28Q4edyFdmHBpdDl5Sq42ltDFuXRgmU1ykfropUXc ZeKsOXL53IMn1eAIfRGTiGBpZijJqj3im3m4Dfme6PlxmWJ1MW3zoFMzl4d7Lo2rSq ptSL9XV1MZpxPY70DdRutMRxKjdGWeMOJ8ehcNwHU1AwMUrKj+EU0MuJqGVtSO8+sf yhtp+1i8w68tXCnSKS0CcaFSjsQiOYn39XufAXf5YEIYY0Q2GPxmMwRYBlupqKyZ9V /RAfw3YvTmgniiQqDTqlKQqocT1a9db/D6Rxlrnmd4rRedrbD5Mf9S34gyYTWP6qw+ rBNfYevunczPw== From: Thomas Gleixner To: Rosen Penev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86 In-Reply-To: <20260519025703.817197-1-rosenp@gmail.com> References: <20260519025703.817197-1-rosenp@gmail.com> Date: Tue, 19 May 2026 19:16:46 +0200 Message-ID: <8733znxqtd.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, May 18 2026 at 19:57, Rosen Penev wrote: > __irq_entry belongs nowhere in irqchip drivers as it is an > architecture specific annotation. There's no specific architecture > depends for DW_APB_ICTL and there probably shouldn't be. Care to see how that driver is selected? Certainly not by x86. > Fixes: > > drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void' > 33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs) That's fixing nothing because the driver cannot be built on x86 and the architectures which select it have a reason to move the handler into the irqentry.text section via __irq_entry. I'm slowly getting fed up by the AI slob which ends up in my inbox every other day. Thanks, tglx