From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214C33CAE76 for ; Tue, 5 May 2026 20:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778011367; cv=none; b=m8h9+SFc/RVlFXqP+Ld/deloXxv6tmkkMHAZoelYU1WIKMEHT2MGS14fIrjTQQLGwezffCHM76HnlqwwN5AD8g5HvOSYPdFTgqpSmRLZLAJMJm0JPx3EzSkEm9rJI4AQFm80vBEWiUZOTYdNkNfpNENAttHjcHfdKEqn5jnSW0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778011367; c=relaxed/simple; bh=S4mPz1gHjU8JPLMFTOh6+Yltl18mwFwYQmcVdfoQwYE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MG+KQji4aSKfboP3Vf5rZwinwJ27DugWU+cVaduoR2SwplOAK9qpnAzaTykzsYSh3EHPnANiyhQwrUn5Gcaw/EtW10t30bThvBSJW/SoVz0SgeeLyOX8IHC5HX5fZU4hwxS17/o2wCUUYAUEHHVCu7GkRUirSiyQx2mCQXMdmwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hKf4MOXt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hKf4MOXt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D40DEC2BCB4; Tue, 5 May 2026 20:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778011366; bh=S4mPz1gHjU8JPLMFTOh6+Yltl18mwFwYQmcVdfoQwYE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hKf4MOXtyo3lBpMYJ6Kt9fwcEE6MvbIRoZTODnNG4oG3FchXQVHyHvCt6mUU6hWEm 2KL8rM6TvPuav81DG/3vMEpUqZi6Vb1t4u/opmYKBLoNDP3pH+zKIFORb0xxFtO6QT JqqUvGlRVkHGHVQxpe2RbLoQOsUSsa7kR5nRq18CDYwo5SPupLvptoyyPKXhcupBSE /2qyNYCqoRmmZT0Xf/EssG8TMCDPFtNBq+j7faJvGfBIZpKkbMumkJKnuq8APsu8T3 3X2BKPwu3Jv9H7PqTJoUa0+EQp52ihbup4AU4yVBiHsTgcLAFDC0Gyxk5ssz9elJPu QpPt1DchVlb/Q== From: Thomas Gleixner To: Sascha Bischoff , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Cc: nd , Lorenzo Pieralisi , Marc Zyngier Subject: Re: [PATCH 1/3] irqchip/gic-v5: Move LPI alloc/free into LPI domain In-Reply-To: <20260430153352.3654325-2-sascha.bischoff@arm.com> References: <20260430153352.3654325-1-sascha.bischoff@arm.com> <20260430153352.3654325-2-sascha.bischoff@arm.com> Date: Tue, 05 May 2026 22:02:43 +0200 Message-ID: <873405y68s.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Apr 30 2026 at 15:34, Sascha Bischoff wrote: > Rather than relying on the domains built on top of GICv5's LPI domain > to manage LPI allocations and frees, move that into the LPI domain > itself. This, rightly, ensures that domains other than the LPI itself > have no knowledge of LPI allocations themselves. This not only cleans > up the LPI domain itself, but also the IPI and ITS MSI domains which > build upon it. > > While we're at it, drop the helpers wrapping the helpers - > gicv5_alloc_lpi() and gicv5_free_lpi() - and directly use alloc_lpi() > and release_lpi() instead. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog > > +static void gicv5_irq_lpi_domain_free(struct irq_domain *domain, unsigned int virq, > + unsigned int nr_irqs) > +{ > + struct irq_data *d; > + > + if (WARN_ON_ONCE(nr_irqs != 1)) > + return; > + > + d = irq_domain_get_irq_data(domain, virq); > + > + Stray extra newline. > + release_lpi(d->hwirq); > + > + irq_set_handler(virq, NULL); > + irq_domain_reset_irq_data(d); > +} Otherwise this looks good.