public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation: filesystems: cramfs: correct stale hard-link and endianness claims
Date: Sun, 03 May 2026 09:13:00 -0600	[thread overview]
Message-ID: <873408cyrn.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260422211039.270552-1-nico@fluxnic.net>

Nicolas Pitre <nico@fluxnic.net> writes:

> Two paragraphs in cramfs.rst have been misleading for a long time:
>
>  - "Hard links are supported, but hard linked files will still have
>    a link count of 1": mkcramfs does not preserve hard links; it
>    deduplicates by content (eliminate_doubles()).  Two names for
>    the same on-disk inode in the source tree become two separate
>    (content-shared) entries in the image, and cramfs always reports
>    a link count of 1.
>
>  - "Currently, cramfs must be written and read with architectures of
>    the same endianness ... PAGE_SIZE == 4096 ... is a bug, but it
>    hasn't been decided what the best fix is": the endianness
>    situation has been settled for years -- the kernel checks for
>    CRAMFS_MAGIC_WEND in cramfs_fill_super() and refuses the mount,
>    and mkcramfs has gained -B / -L for producing images of the
>    opposite endianness from the build host (useful for cross-builds,
>    but the reader still needs to match).  Restate this accurately.
>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> ---
>  Documentation/filesystems/cramfs.rst | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)

I've applied both patches, thanks.

jon

      parent reply	other threads:[~2026-05-03 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 21:10 [PATCH 1/2] Documentation: filesystems: cramfs: correct stale hard-link and endianness claims Nicolas Pitre
2026-04-22 21:10 ` [PATCH 2/2] cramfs: drop obsolete Future Development notes and update tools URL Nicolas Pitre
2026-05-03 15:13 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873408cyrn.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox