From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D6D286A9 for ; Tue, 24 Feb 2026 08:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771922903; cv=none; b=fvYYx68BEIZEnzXj/1CMLTh7PTVKiZuZnGHP5G6G4HTlsowirfQvqAS6M/O+1hOU9hDjrS0XkYfWiewaACln407/PeH8xONzALBd0ektc2EnKqILwFYbMPat2AyhYsy1hRdROwMWOusERRgZV9L2j52EmLyvoBrwuLq+syTjGYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771922903; c=relaxed/simple; bh=kUlc5FkVaN2XjrDmPuRC/ncEtB+3uiimsdI9shfe8EA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aV88vfkYfRN+G6OWDmgWQasyjxL9vSQ1HyFPVMprp53PAxOzSVnQ5pRYT+nyI5XMZ0pWMuXB7dUNOJiJFOUPBTuo1ETihAURLsI25ee7/Bh7JnSQmv2LCuZeF5FFVr5OryLRXSBzS22hqoT8Ik3Eht2YLW9tJgH5CsboEKPZXdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qS+UlPVk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qS+UlPVk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8062C116D0; Tue, 24 Feb 2026 08:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771922903; bh=kUlc5FkVaN2XjrDmPuRC/ncEtB+3uiimsdI9shfe8EA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qS+UlPVk7iPrd00xMIu3jGTIy7ykUUG35NWX7rTOWHsxzIqUNNHnp/DeGNYyfovms nwgTZzKZS6DAOdk41xj5yzhLokCn3gSUejTql+8a2RaQxxqNvCMnhZYVTFeIYqTOj0 mloLGUJHmYfmpZVK0EQg66hjJa0ucNgkOfRmHSWRpFqZA6pnr60q+dID9nvLZTy1BQ FuhCBc8rk1nS3ECPDuKnf2/3dLp06wPKZFJ97gdLrkYSMN4NcmDIqiCeyi8FpSZNVM XhnodB6AHAdFpVVo8pSsqVOvv9ATIFEiZ0a6Ihr+3dDCNtvR/wxgsmK3xZF6goRkpp MPcdJF7tDB56g== From: Thomas Gleixner To: Zhan Xusheng , John Stultz Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: Re: [PATCH] alarmtimer: Fix kerneldoc comment for alarmtimer_suspend() In-Reply-To: <20260205085159.101801-1-zhanxusheng@xiaomi.com> References: <20260205085159.101801-1-zhanxusheng@xiaomi.com> Date: Tue, 24 Feb 2026 09:48:19 +0100 Message-ID: <87342qv86k.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Feb 05 2026 at 16:51, Zhan Xusheng wrote: > Updated comment to explain that `dev` is used for scheduling > wake-up events. That's just wrong. > Signed-off-by: Zhan Xusheng > --- > kernel/time/alarmtimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c > index 069d93bfb0c7..2548292b207d 100644 > --- a/kernel/time/alarmtimer.c > +++ b/kernel/time/alarmtimer.c > @@ -208,7 +208,7 @@ EXPORT_SYMBOL_GPL(alarm_expires_remaining); > #ifdef CONFIG_RTC_CLASS > /** > * alarmtimer_suspend - Suspend time callback > - * @dev: unused > + * @dev: the device that triggered the suspend, used for wake-up event Which device triggered the suspend? Surely not @dev. The code does not care about @dev as documented because it uses its own mechanism to retrieve the wakeup RTC device. So you replace a perfectly correct comment with incomprehensible garbage. What's the improvement here? Thanks, tglx