Re: [PATCH next] fuse: Uninitialized variable in fuse_epoch_work()

[Luis Henriques <luis@igalia.com>]

On Fri, Nov 21 2025, Dan Carpenter wrote:

> The "fm" pointer is either valid or uninitialized so checking for NULL
> doesn't work.  Check the "inode" pointer instead.

Hmm?  Why do you say 'fm' isn't initialised?  That's what fuse_ilookup()
is doing, isn't it?

Cheers,
-- 
Luís

> Fixes: 64becd224ff9 ("fuse: new work queue to invalidate dentries from old epochs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  fs/fuse/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 761f4a14dc95..ec5042b47abb 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -201,7 +201,7 @@ void fuse_epoch_work(struct work_struct *work)
>  	inode = fuse_ilookup(fc, FUSE_ROOT_ID, &fm);
>  	iput(inode);
>  
> -	if (fm) {
> +	if (inode) {
>  		/* Remove all possible active references to cached inodes */
>  		shrink_dcache_sb(fm->sb);
>  	} else
> -- 
> 2.51.0
>