From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF0EA35898; Thu, 2 Oct 2025 09:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759398066; cv=none; b=JL80r1kML/E6bheDS7OC2MgGYU5Z2uuiGqTWaJ/Avn+QQyvKhYDZq2/cBUn0qWM+LQ+1ocaetjsZaQ7pdPRgiDuIWwmLzoeHgqwkc5vj+i4AE+1qdtTtxMmQyyIoCFWw61LD/lUXs057M5fLC+IvVIBCShPsczNK5dshYeqMVBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759398066; c=relaxed/simple; bh=k3Ggu9qHuMR3/98nQLRefOpVd4fBpGgb6qDPDaeTeuY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=CAYQ0XBvyuXfT94AyMhHEUFnDgP+aOOI6+yMuKF1zY2j/tl+mGdo9Ul4XqrGgTO/MYdNLTrxT3aLGLJnwl0LKn2RGcZwxosJVi6pRAs5xL4GPw9NHnHlK9wOh9UbZ3UcAWfVQjZoUkMRM30Ss7vwWhVOXsnIM9XlhYZZHuXcPYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=XLJOJjXm; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=JfOHkEVH; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="XLJOJjXm"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="JfOHkEVH" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1759398059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3Ggu9qHuMR3/98nQLRefOpVd4fBpGgb6qDPDaeTeuY=; b=XLJOJjXmQUB6A4dwR4EFX7j3HBe/qO8FM3/1MUNDrp11PaA/YmxExsP0GOxwLNaru94LHf KtRvfd7Kk4ySdZcm13hMNCeUHvGkGh2Ny9CM/waEU0V9TcKPKWwuO0O6YLtojE7lFZLoax y0oKZDm1zh+5ZH1HKeoIOydlnIKTu0JTDftYNmcewoTqev9MDeO8ANhWXgiYzN8/Pyf9CP vBz2XFd8gHmqlMzukQPo0SvqjFbteVuweHmZa94v62XMpALS4g9TpPe0MMukI4HTqimx1J Ok6lWUVg6VyZRfvZmujhiC8/ORIfcurZonpkZblNshGIceLLxN2QR0bY2yJJqw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1759398059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3Ggu9qHuMR3/98nQLRefOpVd4fBpGgb6qDPDaeTeuY=; b=JfOHkEVHJb1puWGBlgxK01N+OBSUcLwd+uFsmCU26xZap7KFIjCZB/STfJP8u2W49kZEWy 8TCnNdDuhvCBoECQ== To: Gabriele Monaco , linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org Cc: Gabriele Monaco , Tomas Glozar , Juri Lelli , Clark Williams , John Kacur Subject: Re: [PATCH v2 08/20] verification/dot2c: Remove superfluous enum assignment and add last comma In-Reply-To: <20250919140954.104920-9-gmonaco@redhat.com> References: <20250919140954.104920-1-gmonaco@redhat.com> <20250919140954.104920-9-gmonaco@redhat.com> Date: Thu, 02 Oct 2025 11:40:59 +0200 Message-ID: <873481skt0.fsf@yellow.woof> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Gabriele Monaco writes: > The header files generated by dot2c currently create enums for states > and events assigning the first element to 0. This is superfluous as it > happens automatically if no value is specified. > Also it doesn't add a comma to the last enum elements, which slightly > complicates the diff if states or events are added. > > Remove the assignment to 0 and add a comma to last elements, this > simplifies the logic for the code generator. > > Signed-off-by: Gabriele Monaco There are some minor changes which are not mentioned, but not a big deal: Reviewed-by: Nam Cao